Orchestration in VDMS with Kubernetes#261
Conversation
|
Target CPP Coverage: 64.1421% Target Python Coverage: 98.02% |
|
Target CPP Coverage: 64.2822% Target Python Coverage: 97.94% |
keirafadams
left a comment
There was a problem hiding this comment.
Nothing was leaping out, but I do have some concerns at the level of complexity of the utilities we're bolting on, and think we might want to have a discussion at some point of teasing apart some of the pieces into more isolated libraries/calls (e.g. VCL, K8s support, etc).
That said, approved.
#272) * Format Dockerfiles, convert wget to curl, remove duplicate 'option' in CMakeLists due to cmake warning and centralized in main CmakeLists * Fix base Dockerfile indention --------- Signed-off-by: cwlacewe <chaunte.w.lacewell@intel.com>
cwlacewe
left a comment
There was a problem hiding this comment.
Approved in my POV. @ifadams, can you review/approve the updates?
|
Target CPP Coverage: 64.2822% Target Python Coverage: 97.94% |
keirafadams
left a comment
There was a problem hiding this comment.
Nothing leaping out at me. I forget, is docker compose a separate installation or does it just come with a generic docker install? If it does, did we call that out as a req? My skim was pretty rapid...
|
Target CPP Coverage: 69.7544% Target Python Coverage: 97.94% |
…into kubernetes_support
|
Target CPP Coverage: 69.7544% Target Python Coverage: 97.94% |
Closes #246