Merged
Conversation
luisremis
previously approved these changes
Apr 26, 2018
Contributor
luisremis
left a comment
There was a problem hiding this comment.
This is great. I thought this enhancement would be a mess, but it looks great and simple.
src/rwlock.h
Outdated
| @@ -0,0 +1,196 @@ | |||
| /** | |||
| * @file rwlock.h | |||
Contributor
There was a problem hiding this comment.
the name of the file should be RWLock.h. I am ok if you don't want to change it, but that has been the convention for all other files.
Contributor
There was a problem hiding this comment.
I trust you copy this file from some other project and it has been tested enough :). It will take me long time to review if I cannot assume that.
Contributor
Author
There was a problem hiding this comment.
I will change the name to match the other ones. and yes, Philip went over this again. It is from PMGD with asserts changed to Exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should now be ready to go though I will appreciate more testing with some heavily parallel code.