Closed
Conversation
luisremis
suggested changes
Apr 12, 2018
|
|
||
| int node_ref = get_value<int>(cmd, "_ref", | ||
| query.get_available_reference()); | ||
| int node_ref = get_value<int>(cmd, "_ref", -1); |
Contributor
There was a problem hiding this comment.
this is not right. if link is present (if true on line 167), the node_ref will be -1 if the user did not set _ref.
In other words, if the user does not use _ref and does use link, it will fail.
One possible way to make it right would be to move the link if statement (line 167) up, and based on that set the node_ref.
Contributor
Author
There was a problem hiding this comment.
Good point. I will address that and push new version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fixes to be consistent with API expectations.