-
Notifications
You must be signed in to change notification settings - Fork 32
Workflow: Fix coverage report updates #213
Copy link
Copy link
Closed
Labels
BugIndicates unexpected or undesired behaviorsIndicates unexpected or undesired behaviorsWorkflowImprovements specific to development workflow (i.e. CI changes, unit testing, etc.)Improvements specific to development workflow (i.e. CI changes, unit testing, etc.)
Milestone
Description
Describe the bug
Currently, the updated coverage reports aren't being pushed if the coverage threshold is not satisfied (Results job fails) even if manually approved. This is shown in PR #209 which will affect coverage comparisons for upcoming PRs.
High chances of new PRs failing because comparing to old coverage values/reports.
Expected behavior
Even if comparison is below threshold, update coverage reports/values for current PR. This will involve removing success check for Update job because currently the job is completely skipped if this occurs and doesn't update anything.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
BugIndicates unexpected or undesired behaviorsIndicates unexpected or undesired behaviorsWorkflowImprovements specific to development workflow (i.e. CI changes, unit testing, etc.)Improvements specific to development workflow (i.e. CI changes, unit testing, etc.)
