This repository was archived by the owner on Mar 16, 2026. It is now read-only.
Fix config loading defaults and error handling#9
Merged
il-steffen merged 1 commit intoIntelLabs:masterfrom Oct 14, 2022
Merged
Conversation
Contributor
il-steffen
commented
Sep 19, 2022
- System default is actually at kafl_fuzzer/config_default.yaml
- Setting KAFL_CONFIG_FILE is now optional to override system default
- Fix order to let CWD/kafl.yaml override KAFL_CONFIG_FILE
- Catch + handle when failing to load $CWD/kafl.yaml or KAFL_CONFIG_FILE
- Clarify changes in config_default.yaml
Contributor
Author
|
Note: We abort if KAFL_CONFIG_FILE is set but the file fails to load. Since kafl.yaml does not exist anymore we need to update env.sh to either unset KAFL_CONFIG_FILE or point to a new/empty/duplicate default config? |
516ab21 to
2c5431d
Compare
2c5431d to
b744b15
Compare
- System default is actually at kafl_fuzzer/config_default.yaml Setting KAFL_CONFIG_FILE is now optional to override the system default - Fix loading order to let CWD/kafl.yaml override KAFL_CONFIG_FILE Complain + abort when $CWD/kafl.yaml or KAFL_CONFIG_FILE are set but not loading Document changes in config_default.yaml
b744b15 to
e34b1ef
Compare
Contributor
Author
|
Rebase with fixed up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.