This repository was archived by the owner on Mar 16, 2026. It is now read-only.
also detect qemu.start() failure and avoid double-shutdown#30
Merged
il-steffen merged 1 commit intoIntelLabs:masterfrom Nov 7, 2022
Merged
also detect qemu.start() failure and avoid double-shutdown#30il-steffen merged 1 commit intoIntelLabs:masterfrom
il-steffen merged 1 commit intoIntelLabs:masterfrom
Conversation
- raise and detect ABORT during qemu.start(), before first READY - when first VM aborts and no snapshot is created, nobody gets READY - if none are ready but someone has aborted, let manager exit - use qemu.async_exit() to avoid duplicate execution of qemu.shutdown()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves on #25 which was not handling errors during qemu.start() phase. In this case, the Worker-00 will typically not create the snapshot, which leads all other Workers to wait forever on snapshot creation.
Fix: