Replace custom logger with stdlib logging#17
Conversation
e1799bc to
34bc4be
Compare
|
Thanks a lot! Comparing some old/new log output:
The level+module prefix is nice but unfortunately destroys alignment, making it really hard to find something useful in the log: I think we want to use names based on subsystems, not module hierarchy, and append them to the Worker-N notation for alignment. Similar to shown in the last few lines here. This is not totally consistent in the code right now, but we can fix it some other time. (Some modules need to be turned into a class first so that we can properly hand down a logger module to them.) One more thing - maybe we want to restore console output to normal verbosity once --log is provided? |
|
Thanks for the review ! TODO overview
|
34bc4be to
e1d5e67
Compare
|
@il-steffen regarding the "Worker-N" prefix, I moved the Is this output the one you expect ? (in terms of Worker-xx prefix) |
|
Yes that is how it should look. I had the same I would avoid the extra colon separators as well, or put a space after colon. |
a35dfb4 to
681eeb8
Compare
681eeb8 to
877440b
Compare

This PR replaces the custom logger.py with a python stdlib logging library implementation.
kafl_fuzzer/logging.yaml(file is installed with the kafl_fuzzer package)dictConfiglogging.LoggerAdapterto prefix their own messages withos.getpid()and their own fuzzerpidas welllogging.info('%s ....', % self)debug.logtofuzzer.login the work dirExample output for workers:

Help to fix #1
Opened Items