Skip to content

vonagebusiness: removed unnecessary appName and blockingProcesses#2238

Merged
bartreardon merged 1 commit intoInstallomator:mainfrom
hwlans:vonagebusiness-update
Mar 24, 2025
Merged

vonagebusiness: removed unnecessary appName and blockingProcesses#2238
bartreardon merged 1 commit intoInstallomator:mainfrom
hwlans:vonagebusiness-update

Conversation

@hwlans
Copy link
Contributor

@hwlans hwlans commented Mar 12, 2025

Have you confirmed this pull request is not a duplicate?
YES

Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
YES

Did you use our editorconfig file?
YES

Additional context Add any other context about the label or fix here.

Installomator log

./assemble.sh vonagebusiness
2025-03-12 21:59:54 : INFO  : vonagebusiness : Total items in argumentsArray: 0
2025-03-12 21:59:54 : INFO  : vonagebusiness : argumentsArray:
2025-03-12 21:59:54 : REQ   : vonagebusiness : ################## Start Installomator v. 10.8beta, date 2025-03-12
2025-03-12 21:59:54 : INFO  : vonagebusiness : ################## Version: 10.8beta
2025-03-12 21:59:54 : INFO  : vonagebusiness : ################## Date: 2025-03-12
2025-03-12 21:59:54 : INFO  : vonagebusiness : ################## vonagebusiness
2025-03-12 21:59:54 : DEBUG : vonagebusiness : DEBUG mode 1 enabled.
2025-03-12 21:59:55 : INFO  : vonagebusiness : Reading arguments again:
2025-03-12 21:59:55 : DEBUG : vonagebusiness : name=Vonage Business
2025-03-12 21:59:55 : DEBUG : vonagebusiness : appName=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : type=dmg
2025-03-12 21:59:55 : DEBUG : vonagebusiness : archiveName=VonageBusinessSetup.dmg
2025-03-12 21:59:55 : DEBUG : vonagebusiness : downloadURL=https://vbc-downloads.vonage.com/mac/VonageBusinessSetup.dmg
2025-03-12 21:59:55 : DEBUG : vonagebusiness : curlOptions=-L -O --compressed
2025-03-12 21:59:55 : DEBUG : vonagebusiness : appNewVersion=2.23.0
2025-03-12 21:59:55 : DEBUG : vonagebusiness : appCustomVersion function: Not defined
2025-03-12 21:59:55 : DEBUG : vonagebusiness : versionKey=CFBundleShortVersionString
2025-03-12 21:59:55 : DEBUG : vonagebusiness : packageID=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : pkgName=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : choiceChangesXML=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : expectedTeamID=E37FZSUGQP
2025-03-12 21:59:55 : DEBUG : vonagebusiness : blockingProcesses=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : installerTool=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : CLIInstaller=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : CLIArguments=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : updateTool=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : updateToolArguments=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : updateToolRunAsCurrentUser=
2025-03-12 21:59:55 : INFO  : vonagebusiness : BLOCKING_PROCESS_ACTION=tell_user
2025-03-12 21:59:55 : INFO  : vonagebusiness : NOTIFY=success
2025-03-12 21:59:55 : INFO  : vonagebusiness : LOGGING=DEBUG
2025-03-12 21:59:55 : INFO  : vonagebusiness : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-03-12 21:59:55 : INFO  : vonagebusiness : Label type: dmg
2025-03-12 21:59:55 : INFO  : vonagebusiness : archiveName: VonageBusinessSetup.dmg
2025-03-12 21:59:55 : INFO  : vonagebusiness : no blocking processes defined, using Vonage Business as default
2025-03-12 21:59:55 : DEBUG : vonagebusiness : Changing directory to /Users/h.lans/Documents/GitHub/Installomator/build
2025-03-12 21:59:55 : INFO  : vonagebusiness : name: Vonage Business, appName: Vonage Business.app
2025-03-12 21:59:55 : WARN  : vonagebusiness : No previous app found
2025-03-12 21:59:55 : WARN  : vonagebusiness : could not find Vonage Business.app
2025-03-12 21:59:55 : INFO  : vonagebusiness : appversion:
2025-03-12 21:59:55 : INFO  : vonagebusiness : Latest version of Vonage Business is 2.23.0
2025-03-12 21:59:55 : INFO  : vonagebusiness : VonageBusinessSetup.dmg exists and DEBUG mode 1 enabled, skipping download
2025-03-12 21:59:55 : DEBUG : vonagebusiness : DEBUG mode 1, not checking for blocking processes
2025-03-12 21:59:55 : REQ   : vonagebusiness : Installing Vonage Business
2025-03-12 21:59:55 : INFO  : vonagebusiness : Mounting /Users/h.lans/Documents/GitHub/Installomator/build/VonageBusinessSetup.dmg
2025-03-12 21:59:55 : DEBUG : vonagebusiness : Debugging enabled, dmgmount output was:
expected CRC32 $41FF733A
/dev/disk4          	GUID_partition_scheme
/dev/disk4s1        	Apple_HFS                      	/Volumes/Vonage Business 2.23.0-universal

2025-03-12 21:59:55 : INFO  : vonagebusiness : Mounted: /Volumes/Vonage Business 2.23.0-universal
2025-03-12 21:59:55 : INFO  : vonagebusiness : Verifying: /Volumes/Vonage Business 2.23.0-universal/Vonage Business.app
2025-03-12 21:59:55 : DEBUG : vonagebusiness : App size: 536M	/Volumes/Vonage Business 2.23.0-universal/Vonage Business.app
2025-03-12 21:59:58 : DEBUG : vonagebusiness : Debugging enabled, App Verification output was:
/Volumes/Vonage Business 2.23.0-universal/Vonage Business.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: Vonage Holdings Corp. (E37FZSUGQP)

2025-03-12 21:59:58 : INFO  : vonagebusiness : Team ID matching: E37FZSUGQP (expected: E37FZSUGQP )
2025-03-12 21:59:58 : INFO  : vonagebusiness : Installing Vonage Business version 2.23.0 on versionKey CFBundleShortVersionString.
2025-03-12 21:59:58 : INFO  : vonagebusiness : App has LSMinimumSystemVersion: 10.11.0
2025-03-12 21:59:58 : DEBUG : vonagebusiness : DEBUG mode 1 enabled, skipping remove, copy and chown steps
2025-03-12 21:59:58 : INFO  : vonagebusiness : Finishing...
2025-03-12 22:00:01 : INFO  : vonagebusiness : name: Vonage Business, appName: Vonage Business.app
2025-03-12 22:00:01 : WARN  : vonagebusiness : No previous app found
2025-03-12 22:00:01 : WARN  : vonagebusiness : could not find Vonage Business.app
2025-03-12 22:00:01 : REQ   : vonagebusiness : Installed Vonage Business, version 2.23.0
2025-03-12 22:00:01 : INFO  : vonagebusiness : notifying
2025-03-12 22:00:01 : DEBUG : vonagebusiness : Unmounting /Volumes/Vonage Business 2.23.0-universal
2025-03-12 22:00:01 : DEBUG : vonagebusiness : Debugging enabled, Unmounting output was:
"disk4" ejected.
2025-03-12 22:00:01 : DEBUG : vonagebusiness : DEBUG mode 1, not reopening anything
2025-03-12 22:00:01 : REQ   : vonagebusiness : All done!
2025-03-12 22:00:01 : REQ   : vonagebusiness : ################## End Installomator, exit code 0

Please identify any issues fixed by your pull request by including the issue number. (Example: "Fixes #XXXX")

````
./assemble.sh vonagebusiness
2025-03-12 21:59:54 : INFO  : vonagebusiness : Total items in argumentsArray: 0
2025-03-12 21:59:54 : INFO  : vonagebusiness : argumentsArray:
2025-03-12 21:59:54 : REQ   : vonagebusiness : ################## Start Installomator v. 10.8beta, date 2025-03-12
2025-03-12 21:59:54 : INFO  : vonagebusiness : ################## Version: 10.8beta
2025-03-12 21:59:54 : INFO  : vonagebusiness : ################## Date: 2025-03-12
2025-03-12 21:59:54 : INFO  : vonagebusiness : ################## vonagebusiness
2025-03-12 21:59:54 : DEBUG : vonagebusiness : DEBUG mode 1 enabled.
2025-03-12 21:59:55 : INFO  : vonagebusiness : Reading arguments again:
2025-03-12 21:59:55 : DEBUG : vonagebusiness : name=Vonage Business
2025-03-12 21:59:55 : DEBUG : vonagebusiness : appName=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : type=dmg
2025-03-12 21:59:55 : DEBUG : vonagebusiness : archiveName=VonageBusinessSetup.dmg
2025-03-12 21:59:55 : DEBUG : vonagebusiness : downloadURL=https://vbc-downloads.vonage.com/mac/VonageBusinessSetup.dmg
2025-03-12 21:59:55 : DEBUG : vonagebusiness : curlOptions=-L -O --compressed
2025-03-12 21:59:55 : DEBUG : vonagebusiness : appNewVersion=2.23.0
2025-03-12 21:59:55 : DEBUG : vonagebusiness : appCustomVersion function: Not defined
2025-03-12 21:59:55 : DEBUG : vonagebusiness : versionKey=CFBundleShortVersionString
2025-03-12 21:59:55 : DEBUG : vonagebusiness : packageID=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : pkgName=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : choiceChangesXML=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : expectedTeamID=E37FZSUGQP
2025-03-12 21:59:55 : DEBUG : vonagebusiness : blockingProcesses=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : installerTool=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : CLIInstaller=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : CLIArguments=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : updateTool=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : updateToolArguments=
2025-03-12 21:59:55 : DEBUG : vonagebusiness : updateToolRunAsCurrentUser=
2025-03-12 21:59:55 : INFO  : vonagebusiness : BLOCKING_PROCESS_ACTION=tell_user
2025-03-12 21:59:55 : INFO  : vonagebusiness : NOTIFY=success
2025-03-12 21:59:55 : INFO  : vonagebusiness : LOGGING=DEBUG
2025-03-12 21:59:55 : INFO  : vonagebusiness : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-03-12 21:59:55 : INFO  : vonagebusiness : Label type: dmg
2025-03-12 21:59:55 : INFO  : vonagebusiness : archiveName: VonageBusinessSetup.dmg
2025-03-12 21:59:55 : INFO  : vonagebusiness : no blocking processes defined, using Vonage Business as default
2025-03-12 21:59:55 : DEBUG : vonagebusiness : Changing directory to /Users/h.lans/Documents/GitHub/Installomator/build
2025-03-12 21:59:55 : INFO  : vonagebusiness : name: Vonage Business, appName: Vonage Business.app
2025-03-12 21:59:55 : WARN  : vonagebusiness : No previous app found
2025-03-12 21:59:55 : WARN  : vonagebusiness : could not find Vonage Business.app
2025-03-12 21:59:55 : INFO  : vonagebusiness : appversion:
2025-03-12 21:59:55 : INFO  : vonagebusiness : Latest version of Vonage Business is 2.23.0
2025-03-12 21:59:55 : INFO  : vonagebusiness : VonageBusinessSetup.dmg exists and DEBUG mode 1 enabled, skipping download
2025-03-12 21:59:55 : DEBUG : vonagebusiness : DEBUG mode 1, not checking for blocking processes
2025-03-12 21:59:55 : REQ   : vonagebusiness : Installing Vonage Business
2025-03-12 21:59:55 : INFO  : vonagebusiness : Mounting /Users/h.lans/Documents/GitHub/Installomator/build/VonageBusinessSetup.dmg
2025-03-12 21:59:55 : DEBUG : vonagebusiness : Debugging enabled, dmgmount output was:
expected CRC32 $41FF733A
/dev/disk4          	GUID_partition_scheme
/dev/disk4s1        	Apple_HFS                      	/Volumes/Vonage Business 2.23.0-universal

2025-03-12 21:59:55 : INFO  : vonagebusiness : Mounted: /Volumes/Vonage Business 2.23.0-universal
2025-03-12 21:59:55 : INFO  : vonagebusiness : Verifying: /Volumes/Vonage Business 2.23.0-universal/Vonage Business.app
2025-03-12 21:59:55 : DEBUG : vonagebusiness : App size: 536M	/Volumes/Vonage Business 2.23.0-universal/Vonage Business.app
2025-03-12 21:59:58 : DEBUG : vonagebusiness : Debugging enabled, App Verification output was:
/Volumes/Vonage Business 2.23.0-universal/Vonage Business.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: Vonage Holdings Corp. (E37FZSUGQP)

2025-03-12 21:59:58 : INFO  : vonagebusiness : Team ID matching: E37FZSUGQP (expected: E37FZSUGQP )
2025-03-12 21:59:58 : INFO  : vonagebusiness : Installing Vonage Business version 2.23.0 on versionKey CFBundleShortVersionString.
2025-03-12 21:59:58 : INFO  : vonagebusiness : App has LSMinimumSystemVersion: 10.11.0
2025-03-12 21:59:58 : DEBUG : vonagebusiness : DEBUG mode 1 enabled, skipping remove, copy and chown steps
2025-03-12 21:59:58 : INFO  : vonagebusiness : Finishing...
2025-03-12 22:00:01 : INFO  : vonagebusiness : name: Vonage Business, appName: Vonage Business.app
2025-03-12 22:00:01 : WARN  : vonagebusiness : No previous app found
2025-03-12 22:00:01 : WARN  : vonagebusiness : could not find Vonage Business.app
2025-03-12 22:00:01 : REQ   : vonagebusiness : Installed Vonage Business, version 2.23.0
2025-03-12 22:00:01 : INFO  : vonagebusiness : notifying
2025-03-12 22:00:01 : DEBUG : vonagebusiness : Unmounting /Volumes/Vonage Business 2.23.0-universal
2025-03-12 22:00:01 : DEBUG : vonagebusiness : Debugging enabled, Unmounting output was:
"disk4" ejected.
2025-03-12 22:00:01 : DEBUG : vonagebusiness : DEBUG mode 1, not reopening anything
2025-03-12 22:00:01 : REQ   : vonagebusiness : All done!
2025-03-12 22:00:01 : REQ   : vonagebusiness : ################## End Installomator, exit code 0
````
@bartreardon bartreardon added application adds or improves an application label validated App label that has been validated by the validation bot labels Mar 20, 2025
@bartreardon
Copy link
Collaborator

🤖 Validation robot 🤖
File fragments/labels/vonagebusiness.sh
** Label info:
├ ✅ correct line ending
├ ✅ Name: Vonage Business
├ ✅ Type: dmg
├ ✅ Expected Team: E37FZSUGQP
├ ✅ App New Version: 2.23.0
└ Download URL: https://vbc-downloads.vonage.com/mac/VonageBusinessSetup.dmg
├ ✅ URL is reachable
└ ✅ Download Size: 208.5 MB
✅ All checks passed


@bartreardon bartreardon added this to the v10.8 milestone Mar 21, 2025
@bartreardon
Copy link
Collaborator

Thank you!

@bartreardon bartreardon merged commit e9bd175 into Installomator:main Mar 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application adds or improves an application label validated App label that has been validated by the validation bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants