You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All questions must be filled out or your Pull Request will be closed for lack of information. The first three questions should be answered Yes before submitting the pull request.
Have you confirmed this pull request is not a duplicate?
Yes
Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
Yes
Additional context Add any other context about the label or fix here.
Fixes issue #2174 from details provided. Under parseURL(), htmlDocument is missing $curlOptions
Installomator log
2025-02-10 09:26:11 : REQ : citrixworkspace : ################## Start Installomator v. 10.7, date 2025-01-24
2025-02-10 09:26:11 : INFO : citrixworkspace : ################## Version: 10.7
2025-02-10 09:26:11 : INFO : citrixworkspace : ################## Date: 2025-01-24
2025-02-10 09:26:11 : INFO : citrixworkspace : ################## citrixworkspace
2025-02-10 09:26:12 : INFO : citrixworkspace : setting variable from argument DEBUG=0
2025-02-10 09:26:13 : INFO : citrixworkspace : BLOCKING_PROCESS_ACTION=tell_user
2025-02-10 09:26:13 : INFO : citrixworkspace : NOTIFY=success
2025-02-10 09:26:13 : INFO : citrixworkspace : LOGGING=INFO
2025-02-10 09:26:13 : INFO : citrixworkspace : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-02-10 09:26:13 : INFO : citrixworkspace : Label type: pkgInDmg
2025-02-10 09:26:13 : INFO : citrixworkspace : archiveName: Citrix Workspace.dmg
2025-02-10 09:26:13 : INFO : citrixworkspace : no blocking processes defined, using Citrix Workspace as default
2025-02-10 09:26:13 : INFO : citrixworkspace : name: Citrix Workspace, appName: Citrix Workspace.app
2025-02-10 09:26:13.144 mdfind[7966:95071] [UserQueryParser] Loading keywords and predicates for locale "en_US"
2025-02-10 09:26:13.144 mdfind[7966:95071] [UserQueryParser] Loading keywords and predicates for locale "en"
2025-02-10 09:26:13.192 mdfind[7966:95071] Couldn't determine the mapping between prefab keywords and predicates.
2025-02-10 09:26:13 : WARN : citrixworkspace : No previous app found
2025-02-10 09:26:13 : WARN : citrixworkspace : could not find Citrix Workspace.app
2025-02-10 09:26:13 : INFO : citrixworkspace : appversion:
2025-02-10 09:26:13 : INFO : citrixworkspace : Latest version not specified.
2025-02-10 09:26:13 : REQ : citrixworkspace : Downloading https://downloads.citrix.com/23247/CitrixWorkspaceApp.dmg?__gda__=exp=1739201172~acl=/*~hmac=b60334bac9faf07570da639519136312d49362b60ff84291a5a9de7705b44415 to Citrix Workspace.dmg
2025-02-10 09:26:19 : REQ : citrixworkspace : no more blocking processes, continue with update
2025-02-10 09:26:19 : REQ : citrixworkspace : Installing Citrix Workspace
2025-02-10 09:26:19 : INFO : citrixworkspace : Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.x9JekR0BM6/Citrix Workspace.dmg
2025-02-10 09:26:20 : INFO : citrixworkspace : Mounted: /Volumes/Citrix Workspace
2025-02-10 09:26:20 : INFO : citrixworkspace : found pkg: /Volumes/Citrix Workspace/Install Citrix Workspace.pkg
2025-02-10 09:26:20 : INFO : citrixworkspace : Verifying: /Volumes/Citrix Workspace/Install Citrix Workspace.pkg
2025-02-10 09:26:20 : INFO : citrixworkspace : Team ID: S272Y5R93J (expected: S272Y5R93J )
2025-02-10 09:26:20 : INFO : citrixworkspace : Installing /Volumes/Citrix Workspace/Install Citrix Workspace.pkg to /
2025-02-10 09:26:59 : INFO : citrixworkspace : Finishing...
2025-02-10 09:27:02 : INFO : citrixworkspace : App(s) found: /Applications/Citrix Workspace.app
2025-02-10 09:27:02 : INFO : citrixworkspace : found app at /Applications/Citrix Workspace.app, version 24.11.10.22, on versionKey CitrixVersionString
2025-02-10 09:27:02 : REQ : citrixworkspace : Installed Citrix Workspace
2025-02-10 09:27:02 : INFO : citrixworkspace : notifying
2025-02-10 09:27:03 : INFO : citrixworkspace : Installomator did not close any apps, so no need to reopen any apps.
2025-02-10 09:27:03 : REQ : citrixworkspace : All done!
2025-02-10 09:27:03 : REQ : citrixworkspace : ################## End Installomator, exit code 0
Thank you for the fix.
If you also add $curlOptions to line 14 the newVersionString is working again as well.
And no real problem but i noticed you have 2 spaces before the $curlOptions in Line 8.
Thank you for the fix. If you also add $curlOptions to line 14 the newVersionString is working again as well. And no real problem but i noticed you have 2 spaces before the $curlOptions in Line 8.
Thanks, didn't notice the spacing issue. I went ahead and added $curlOptions to line 14 as well. In my testing it didn't make a difference, but shouldn't hurt including it there as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applicationadds or improves an application labelvalidatedApp label that has been validated by the validation bot
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All questions must be filled out or your Pull Request will be closed for lack of information. The first three questions should be answered
Yesbefore submitting the pull request.Have you confirmed this pull request is not a duplicate?
Yes
Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
Yes
Did you use our editorconfig file?
Yes
Additional context Add any other context about the label or fix here.
Fixes issue #2174 from details provided. Under parseURL(), htmlDocument is missing $curlOptions
Installomator log