Skip to content

ENH: Add valgrind suppression file for Ubuntu 22.04 LTS #5360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blowekamp merged 1 commit into from
May 22, 2025
Merged

ENH: Add valgrind suppression file for Ubuntu 22.04 LTS #5360

blowekamp merged 1 commit into from
May 22, 2025

Conversation

@blowekamp
Copy link
Member

@blowekamp blowekamp commented May 22, 2025

Addresses the following false positive:
https://open.cdash.org/viewDynamicAnalysisFile.php?id=11303601

Tested yesterday:
SimpleITK/SimpleITK#2298

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation labels May 22, 2025
@blowekamp blowekamp mentioned this pull request May 22, 2025
Merged
dzenanz
dzenanz reviewed May 22, 2025
View reviewed changes
jhlegarreta
jhlegarreta approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not investigated the valgrind defect, but looks good to me if we have identified it as a false positive.

@blowekamp blowekamp merged commit 4c028be into InsightSoftwareConsortium:master May 22, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz left review comments

@jhlegarreta jhlegarreta jhlegarreta approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees

No one assigned

Labels

type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blowekamp @dzenanz @jhlegarreta