BUG: Incorrect size for looping closed parametric dimension.#5242
BUG: Incorrect size for looping closed parametric dimension.#5242thewtex merged 5 commits intoInsightSoftwareConsortium:masterfrom
Conversation
|
|
|
Thanks @dzenanz . The baseline image is incorrect and needs to be updated. It's been so long that I've forgotten how to update it. Do you happen to have a link to documentation to help remind myself of the procedure? Thanks. |
|
Just for completeness, below is a side-by-side comparison of the current baseline image (left) and what it should be (right). 
(Edited to add the correct images.) |
|
Upload the correct baseline here, then click "download .cid file", and put that new file in the correct place in the repository ( |
| @@ -1 +1 @@ | |||
| bafkreifhzzuhtzerxqynchashazjhqlmp6jpipvp6j5azkbfjfla5nuuxm | |||
| bafkreigzmzk6nws4pgxdbildcqclzog7gmnsnsuw2tavurzoioma3sktay | |||
There was a problem hiding this comment.
Misspelling in commit message caorrect -> correct
|
The test is still failing, see e.g. https://open.cdash.org/tests/1915207818. |
|
My apologies @dzenanz but I was working with an older snapshot of ITK so the output image wasn't quite correct. I'm trying to upload a new version of the baseline image for testing but after the login screen I'm not seeing the upload options as before. Is the link still valid or am I missing something? |
|
The actual instructions are here. I guess that the main upload tool stopped working properly. |
thewtex
left a comment
There was a problem hiding this comment.
@ntustison thanks for contributing this fix 🙏 .
I will also backport it for ITK 5.4.3.
BUG: Incorrect size for looping closed parametric dimension.
Bug producing an incorrect result for the specific case of a closed parametric dimension, e.g., closed loop or cylinder. This doesn't effect the usual image output.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.