COMP: Fix AnatomicalOrientation Enum#4899
Merged
blowekamp merged 1 commit intoInsightSoftwareConsortium:masterfrom Oct 25, 2024
Merged
COMP: Fix AnatomicalOrientation Enum#4899blowekamp merged 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
dzenanz
approved these changes
Oct 24, 2024
thewtex
approved these changes
Oct 24, 2024
Member
thewtex
left a comment
There was a problem hiding this comment.
🚀 @blowekamp thanks for the quick follow-up
N-Dekker
reviewed
Oct 24, 2024
| spacing.SetIdentity(); | ||
|
|
||
| AnatomicalOrientation coord_orient(AnatomicalOrientation::FromEnum::RSA); | ||
| AnatomicalOrientation coord_orient(AnatomicalOrientation::NegativeEnum::RSA); |
Contributor
There was a problem hiding this comment.
Thanks @blowekamp! Just for my understanding, why NegativeEnum, why not PositiveEnum ? They both have an RSA constant, right?
Member
Author
There was a problem hiding this comment.
They were originally ToEnum, and FromEnum, then renamed to PositiveEnum and NegativeEnum. That change was applied here. There should be a description of these two ambiguous notations in the AnatomicalOrientation class. Please read it and let me know if you have specific suggestions to improve clarity.
This particular value is not used, but is require as AnatomicalOrientation is not default constructible ( perhaps INVALID) would be a reasonable default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses compilation errors on optional module.