Skip to content

refactor: use range-based for loop to enhance readability#27

Merged
Inokinoki merged 2 commits intoInokinoki:masterfrom
Integral-Tech:ranged-based-for
Nov 8, 2024
Merged

refactor: use range-based for loop to enhance readability#27
Inokinoki merged 2 commits intoInokinoki:masterfrom
Integral-Tech:ranged-based-for

Conversation

@Integral-Tech
Copy link
Contributor

No description provided.

@Integral-Tech Integral-Tech force-pushed the ranged-based-for branch 10 times, most recently from 4dbd989 to 5547849 Compare October 30, 2024 19:09
@Inokinoki
Copy link
Owner

Wait for test on FreeBSD to check G++ version and standard flag to add @Inokinoki

@Inokinoki
Copy link
Owner

Inokinoki commented Nov 7, 2024

Wait for test on FreeBSD to check G++ version and standard flag to add @Inokinoki

Thanks! It works greatly with g++ on FreeBSD after specifying the CXX standard version:

Screenshot 2024-11-07 at 7 33 50 PM

Please explicitly update CMAKE_CXX_STANDARD to 17:

Screenshot 2024-11-07 at 7 31 44 PM

@Inokinoki
Copy link
Owner

Inokinoki commented Nov 8, 2024

It requires glibc 2.34 thererfore:

$ ldd /mnt/c/QEFI\ Entry\ Manager\ x86_64\ AppImage/QEFIEntryManager
/mnt/c/QEFI Entry Manager x86_64 AppImage/QEFIEntryManager: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /mnt/c/QEFI Entry Manager x86_64 AppImage/QEFIEntryManager)

Let me check the compatibilities in any case

whereas Ubuntu 20.04 gives 2.31:

https://github.com/Inokinoki/QEFIEntryManager/actions/runs/11746370624/job/32725968629#step:3:7

The support of 20.04 will not step by April 2025, I think we can do the upgrade later then.

Or would you mind to import another github workflow to install qt6/install through their installer?

@Integral-Tech Integral-Tech force-pushed the ranged-based-for branch 6 times, most recently from 0a6e552 to c8b45ad Compare November 8, 2024 19:41
@Integral-Tech
Copy link
Contributor Author

@Inokinoki Fixed :)

Copy link
Owner

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🙏 Thanks very much!

@Inokinoki Inokinoki merged commit ee0651c into Inokinoki:master Nov 8, 2024
@Integral-Tech Integral-Tech deleted the ranged-based-for branch November 9, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants