fix: trimmed headers for object result#66
Merged
touv merged 1 commit intoInist-CNRS:masterfrom Oct 3, 2022
Merged
Conversation
Contributor
Author
|
Separately, I noticed that I failed to run linting on my last PR. I didn't want to fill this PR up with a bunch of linting changes, but I'd be happy to submit a separate PR after this one to fix linting (and maybe make it automatic with husky?) |
Collaborator
|
Thank you, indeed, it is a good idea to clean the headers |
Collaborator
|
I just released v4.1.1 to include this fix |
Contributor
Author
|
Thank you for your prompt attention! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65
@touv I know I didn't give you any time to comment on this issue, but I figured I'd submit this fix and if you find it controversial we can talk about it here. Please let me know!