Skip to content

fix: add ut for backend runtime. #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
InftyAI-Agent merged 2 commits into from
Jun 2, 2025
Merged

fix: add ut for backend runtime. #428

InftyAI-Agent merged 2 commits into from
Jun 2, 2025

Conversation

@X1aoZEOuO
Copy link
Contributor

@X1aoZEOuO X1aoZEOuO commented May 22, 2025 •
edited
Loading

What this PR does / why we need it

Add mode unit tests for backend runtime.

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

From:

github.com/inftyai/llmaz/pkg/controller_helper/backendruntime   0.016s  coverage: 35.9% of statements

To:

github.com/inftyai/llmaz/pkg/controller_helper/backendruntime   0.016s  coverage: 69.2% of statements

cc @kerthcet

Does this PR introduce a user-facing change?

Add ut for backend runtime.

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels May 22, 2025
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet May 22, 2025 03:11
@X1aoZEOuO
Copy link
Contributor Author

X1aoZEOuO commented May 22, 2025

/kind cleanup

@InftyAI-Agent InftyAI-Agent added cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels May 22, 2025
@kerthcet
Copy link
Member

kerthcet commented May 22, 2025

Would you like to take a view first @googs1025

@googs1025
Copy link
Member

googs1025 commented May 22, 2025

/cc

sure. I'll take a look today 😄

@InftyAI-Agent InftyAI-Agent requested a review from googs1025 May 22, 2025 03:57
googs1025
googs1025 reviewed May 22, 2025
View reviewed changes
googs1025
googs1025 reviewed May 22, 2025
View reviewed changes
googs1025
googs1025 reviewed May 22, 2025
View reviewed changes
googs1025
googs1025 reviewed May 22, 2025
View reviewed changes
@kerthcet
Copy link
Member

kerthcet commented May 26, 2025

/approve

Leave the LGTM to @googs1025

@InftyAI-Agent InftyAI-Agent added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
kerthcet
kerthcet reviewed May 27, 2025
View reviewed changes
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit. Otherwise LGTM @X1aoZEOuO

@kerthcet
Copy link
Member

kerthcet commented May 28, 2025

kindly ping @X1aoZEOuO

@X1aoZEOuO
Copy link
Contributor Author

X1aoZEOuO commented May 29, 2025 •
edited
Loading

Sorry, I've been preparing for my final exams these past two days. I'll fix it this weekend. @kerthcet

@X1aoZEOuO X1aoZEOuO force-pushed the fix/add-ut-for-backendruntime branch from 3a8c392 to 0d0c410 Compare June 2, 2025 03:13
@X1aoZEOuO X1aoZEOuO requested review from googs1025 and kerthcet June 2, 2025 03:13
@kerthcet
Copy link
Member

kerthcet commented Jun 2, 2025

/lgtm
Thanks @X1aoZEOuO welcome on board!

@InftyAI-Agent InftyAI-Agent added the lgtm Looks good to me, indicates that a PR is ready to be merged. label Jun 2, 2025
@InftyAI-Agent InftyAI-Agent merged commit 3ca265e into InftyAI:main Jun 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kerthcet kerthcet Awaiting requested review from kerthcet

@googs1025 googs1025 Awaiting requested review from googs1025

Assignees

@kerthcet kerthcet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@X1aoZEOuO @kerthcet @googs1025 @InftyAI-Agent