Skip to content

cleanup: remove kube-rbac-proxy #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
InftyAI-Agent merged 2 commits into from
Mar 21, 2025
Merged

cleanup: remove kube-rbac-proxy #321

InftyAI-Agent merged 2 commits into from
Mar 21, 2025

Conversation

@nayihz
Copy link
Contributor

@nayihz nayihz commented Mar 19, 2025

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes: #211.

Special notes for your reviewer

Does this PR introduce a user-facing change?

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 19, 2025
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet March 19, 2025 11:59
@nayihz nayihz force-pushed the remove-kube-rbac-proxy branch 2 times, most recently from 54abb23 to 600a55b Compare March 20, 2025 06:20
@nayihz nayihz changed the title {WIP}cleanup: remove kube-rbac-proxy cleanup: remove kube-rbac-proxy Mar 20, 2025
@nayihz
Copy link
Contributor Author

nayihz commented Mar 20, 2025

/kind cleanup
/assign @kerthcet

@InftyAI-Agent InftyAI-Agent added cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 20, 2025
kerthcet
kerthcet reviewed Mar 21, 2025
View reviewed changes
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, generally let's change the kustomize confurations only, and the chart files will be auto generated.

@nayihz nayihz force-pushed the remove-kube-rbac-proxy branch from 600a55b to db10eae Compare March 21, 2025 07:13
@nayihz
Copy link
Contributor Author

nayihz commented Mar 21, 2025

Thanks for your remind. The new chart files are auto generated by make helm. PTAL.

@kerthcet
Copy link
Member

kerthcet commented Mar 21, 2025

/lgtm
/approve

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 21, 2025
@InftyAI-Agent InftyAI-Agent merged commit 0efbe08 into InftyAI:main Mar 21, 2025
19 checks passed
@nayihz nayihz deleted the remove-kube-rbac-proxy branch March 22, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kerthcet kerthcet kerthcet left review comments

Assignees

@kerthcet kerthcet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

⚠️ Action Required: Replace Deprecated gcr.io/kubebuilder/kube-rbac-proxy

3 participants

@nayihz @kerthcet @InftyAI-Agent