Skip to content

Add validation to Playground as the backendConfig's resource requests should not be greater than limits #135

New issue
New issue
Closed
#170
Closed
Add validation to Playground as the backendConfig's resource requests should not be greater than limits#135
#170
Labels
cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.good first issueGood for newcomershelp wantedExtra attention is neededneeds-kindIndicates a PR lacks a label and requires one.needs-priorityIndicates a PR lacks a label and requires one.needs-triageIndicates an issue or PR lacks a label and requires one.
@kerthcet

Description

@kerthcet
kerthcet
opened on Sep 9, 2024

What would you like to be cleaned:

Make sure the resources are qualified.

llmaz/api/inference/v1alpha1/config_types.go

Lines 48 to 52 in 8637aa9

// Resources represents the resource requirements for backend, like cpu/mem,
// accelerators like GPU should not be defined here, but at the Model flavors,
// or the same accelerator requirements defined there will be covered and
// the workload will lose the fungibility capacity.
Resources *ResourceRequirements `json:"resources,omitempty"`

Why is this needed:

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.good first issueGood for newcomershelp wantedExtra attention is neededneeds-kindIndicates a PR lacks a label and requires one.needs-priorityIndicates a PR lacks a label and requires one.needs-triageIndicates an issue or PR lacks a label and requires one.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions