feat: use build-in Python parsing feature for python >= 3.11#89
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 50.52% 46.90% -3.63%
==========================================
Files 39 31 -8
Lines 2276 2019 -257
==========================================
- Hits 1150 947 -203
+ Misses 1126 1072 -54 ☔ View full report in Codecov by Sentry. |
karel-rehor
approved these changes
Jun 11, 2024
Contributor
karel-rehor
left a comment
There was a problem hiding this comment.
Tests pass for me locally. Everything else looks OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use build-in date parsing feature. From version 3.11 the performance is same as for ciso8601.
For more info see - influxdata/influxdb-client-python#657
https://docs.python.org/3/library/datetime.html#datetime.date.fromisoformat
Checklist