feat: move setup tools to build dependency#141
Merged
NguyenHoangSon96 merged 2 commits intomainfrom Jun 10, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 65.44% 65.44%
=======================================
Files 35 35
Lines 2266 2266
=======================================
Hits 1483 1483
Misses 783 783 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
karel-rehor
approved these changes
Jun 3, 2025
Contributor
karel-rehor
left a comment
There was a problem hiding this comment.
Setup steps now work for me. Verified PyPi package using Sonnh's build. All changes make sense. 🚴 🏁
0638535 to
12d8b8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link #695
Proposed Changes
_ Before the fix
_ After the fix: I think the new error message means we have had solved the dependency issue, check out "home-assistant-core/script/hassfest/requirements.py" line 169. The new error message is for the homeassistant team
_ My steps to reproduce the issue:
Checkout Home assistant core repo
Run "source venv/bin/activate"
Run "python3 -m script.gen_requirements_all && pip3.13 install -r requirements_all.txt"
Run "python3 -m script.hassfest --integration-path "home-assistant-core/homeassistant/components/influxdb" --requirement"
My steps to fix
Build influxdb-python3 with the latest change -> Upload to PyPi https://pypi.org/project/sonnh-influxdb3-python/. After that, replace the content of "homeassistant/components/influxdb/manifest.json" like this
manifest.json
Run the same steps as when reproducing the issue again
Checklist