Update serialization workaround of non-dt delay gates post qiskit==2.4.0#1380
Merged
Conversation
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
Contributor
Author
|
Notebook checks expected to pass after server update |
Signed-off-by: Bharath <bharath.thotakura@infleqtion.com>
qiskit~=2.4.0qiskit~=2.4.0
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a workaround to restore successful QPY serialization/deserialization of non-dt qiskit.circuit.Delay instructions after the qiskit~=2.4.0 behavior change, addressing recent qss check failures (closes #1379).
Changes:
- Replaces problematic non-
dtDelayinstructions with a sentinelInstructionduring_prepare_gateto keep QPY serialization working. - Adds a corresponding deserialization path to recognize the sentinel and reconstruct the original
Delay. - Refactors
_resolve_gateby extracting special-case resolution into_resolve_specific_gates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qiskit~=2.4.0qiskit==2.4.0
richrines1
reviewed
Apr 17, 2026
4141811 to
9b93793
Compare
qiskit==2.4.0qiskit==2.4.0
Contributor
Author
|
^ think you missed the approval button haha |
richrines1
approved these changes
Apr 20, 2026
Contributor
oh no sorry just noticed this! :/ |
Contributor
Author
|
Looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes recent failing
qsschecks againstqiskit==2.4.0due toqiskit.circuit.Delayunit information being lost during the deserialization process. Closes: #1379