Skip to content

support fractional counts in jobs#1365

Merged
richrines1 merged 3 commits into
mainfrom
rich/fractional-counts
Apr 6, 2026
Merged

support fractional counts in jobs#1365
richrines1 merged 3 commits into
mainfrom
rich/fractional-counts

Conversation

@richrines1

Copy link
Copy Markdown
Contributor

some jobs may have non-integer "counts" (for example due to MEM). this pr updates various annotations to reflect this

Comment thread general-superstaq/general_superstaq/models.py

@bharat-thotakura bharat-thotakura Apr 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While on this topic, should the counts of process_cb() also be updated? Or would those counts not use something like MEM? Relatedly, but somewhat unrelated to this PR, I'm also unsure why the docstring for process_cb() in general-superstaq/general_superstaq/superstaq_client.py says that the counts are a dict but the type annotation is str | None = None?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yep looks like i missed process_cb, fixed!

for superstaq_client, apparently it's supposed to take a serialized sequence of counts dictionaries so the docstring seems wrong..

that said, really all those qcvv methods do now is raise this:

SuperstaqServerException: Superstaq's ACES, CB, and DFE endpoints have been disabled as we move this functionality to our open-source clients. Stay tuned! (Status code: 400, non-retriable error making request to Superstaq API)

so it might be time to start deleting them? (i believe we left the aces endpoints in place because they're referenced in a paper, but afaik the cb/dfe endpoints are not referenced anywhere and so could be removed now - maybe @vtomole can confirm.) All this is definitely getting outside the scope of this pr though so i'll punt for now :)

@bharat-thotakura bharat-thotakura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richrines1 richrines1 merged commit 76eb15b into main Apr 6, 2026
24 checks passed
@richrines1 richrines1 deleted the rich/fractional-counts branch April 6, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants