support fractional counts in jobs#1365
Conversation
There was a problem hiding this comment.
While on this topic, should the counts of process_cb() also be updated? Or would those counts not use something like MEM? Relatedly, but somewhat unrelated to this PR, I'm also unsure why the docstring for process_cb() in general-superstaq/general_superstaq/superstaq_client.py says that the counts are a dict but the type annotation is str | None = None?
There was a problem hiding this comment.
ah yep looks like i missed process_cb, fixed!
for superstaq_client, apparently it's supposed to take a serialized sequence of counts dictionaries so the docstring seems wrong..
that said, really all those qcvv methods do now is raise this:
SuperstaqServerException: Superstaq's ACES, CB, and DFE endpoints have been disabled as we move this functionality to our open-source clients. Stay tuned! (Status code: 400, non-retriable error making request to Superstaq API)
so it might be time to start deleting them? (i believe we left the aces endpoints in place because they're referenced in a paper, but afaik the cb/dfe endpoints are not referenced anywhere and so could be removed now - maybe @vtomole can confirm.) All this is definitely getting outside the scope of this pr though so i'll punt for now :)
some jobs may have non-integer "counts" (for example due to MEM). this pr updates various annotations to reflect this