Skip to content

Swapping linregress for curve_fit in SU2 analysis#1330

Merged
vietphamngoc merged 8 commits into
mainfrom
vpn/su2_fit_fix
Jan 23, 2026
Merged

Swapping linregress for curve_fit in SU2 analysis#1330
vietphamngoc merged 8 commits into
mainfrom
vpn/su2_fit_fix

Conversation

@vietphamngoc

Copy link
Copy Markdown
Contributor

Now using curve_fit instead of linregress as this won't fail in the odd chance where $P(00) \leq 0.25$.

@pgoiporia pgoiporia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharat-thotakura

Copy link
Copy Markdown
Contributor

(notebook checks are failing for the same reason as #1332)

@cdbf1

cdbf1 commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Notebook tests should pass once #1333 has been deployed server-side

@bharat-thotakura

Copy link
Copy Markdown
Contributor

(notebook checks should pass after #1339 is merged)

@vietphamngoc vietphamngoc merged commit 834b4d8 into main Jan 23, 2026
18 of 21 checks passed
@vietphamngoc vietphamngoc deleted the vpn/su2_fit_fix branch January 23, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants