Skip to content

more verbose error reporting in get_targets integration tests#1329

Merged
richrines1 merged 5 commits into
mainfrom
rich/my-targets-update
Jan 2, 2026
Merged

more verbose error reporting in get_targets integration tests#1329
richrines1 merged 5 commits into
mainfrom
rich/my-targets-update

Conversation

@richrines1

@richrines1 richrines1 commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

in response to recent test flakes

(also cleans up the implementation of get_my_targets)

@bharat-thotakura bharat-thotakura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

Comment thread cirq-superstaq/cirq_superstaq/daily_integration_test.py Outdated
Comment thread qiskit-superstaq/qiskit_superstaq/daily_integration_test.py Outdated
Comment thread qiskit-superstaq/qiskit_superstaq/daily_integration_test.py Outdated
@richrines1

Copy link
Copy Markdown
Contributor Author

(also updated to drop SuperstaqClient.get_my_targets entirely, and instead just have gss.Service.get_my_targets call self.get_targets(..., accessible=True))

@bharat-thotakura bharat-thotakura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM!

@richrines1 richrines1 merged commit 80e99db into main Jan 2, 2026
21 checks passed
@richrines1 richrines1 deleted the rich/my-targets-update branch January 2, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants