cirq <> qiskit converters#1256
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements cirq <> qiskit converters by replacing the existing QASM-based conversion approach with comprehensive native converter functions.
- Adds a new
supermarq/converters/qiskit.pymodule with bidirectional conversion functions - Replaces existing feature computation functions to use native Cirq operations instead of converting to Qiskit
- Removes the old QASM-based converter and associated test files
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| supermarq/features.py | Replaced Qiskit-based feature computation with native Cirq implementations |
| supermarq/converters_test.py | Removed old converter tests |
| supermarq/converters/qiskit_test.py | Added comprehensive tests for new converter functions |
| supermarq/converters/qiskit.py | New comprehensive bidirectional converter implementation |
| supermarq/converters/init.py | Added exports for new converter functions |
| supermarq/converters.py | Removed old QASM-based converter implementation |
| supermarq/benchmarks/mermin_bell_test.py | Removed qiskit_circuit() test calls |
| supermarq/benchmark.py | Removed qiskit_circuit() method |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
vtomole
commented
Jul 30, 2025
| """ | ||
| return self.circuit() | ||
|
|
||
| def qiskit_circuit(self) -> qiskit.QuantumCircuit | list[qiskit.QuantumCircuit]: |
Member
Author
There was a problem hiding this comment.
Put this back. Bring qiskit_qss HPCA tutorial.
Member
Author
There was a problem hiding this comment.
I'm not going to put this back in order to justify putting the converters in Supermarq. Not worth it.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rstaq into qiskit_converters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
supermarq-benchmarks/supermarq/converters/qiskit.py:1
- Corrected spelling of 'ParameterExprsmion' to 'ParameterExpression'.
from __future__ import annotations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rstaq into qiskit_converters
bharat-thotakura
approved these changes
Nov 10, 2025
vtomole
commented
Dec 15, 2025
Member
Author
|
@bharat-thotakura Addressed your comment about moving the test back. Will merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.