Skip to content

feat: add PKI Sectigo External CA docs#5578

Merged
carlosmonastyrski merged 1 commit intomainfrom
feat/PKI-94
Mar 4, 2026
Merged

feat: add PKI Sectigo External CA docs#5578
carlosmonastyrski merged 1 commit intomainfrom
feat/PKI-94

Conversation

@carlosmonastyrski
Copy link
Contributor

Context

Add a new documentation with a guide on how to integrate a Sectigo CA using the existing ACME External CA implementation.

Screenshots

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@linear
Copy link

linear bot commented Mar 4, 2026

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 4, 2026

Greptile Summary

This PR adds documentation for integrating Sectigo as an External CA in Infisical using the existing ACME protocol support, including a new dedicated guide (sectigo.mdx) with step-by-step instructions and screenshots, a navigation entry in docs.json, and a minor update to external-ca.mdx to mention Sectigo in the supported CA list.

The new guide is clear, well-structured, and consistent with the broader PKI documentation patterns. One minor improvement opportunity:

  • The example ACME Directory URL (https://acme.sectigo.com/v2/DV) only represents Domain Validated certificates. Sectigo uses different URL paths per certificate profile (OV, EV, IV), and without a clarifying note, enterprise users needing OV or EV certificates could be directed to the wrong endpoint.

Confidence Score: 5/5

  • This is a documentation-only PR with no code changes — safe to merge.
  • All changes are confined to MDX documentation files, a JSON navigation config, and PNG screenshots. There are no code, API, database, or security-sensitive changes. The single comment flagged is a minor documentation clarity improvement that does not block merging.
  • docs/documentation/platform/pki/ca/sectigo.mdx — line 21 should clarify that the DV URL segment varies by Sectigo certificate profile.

Important Files Changed

Filename Overview
docs/documentation/platform/pki/ca/sectigo.mdx New Sectigo ACME integration guide with step-by-step instructions and screenshots; minor concern that the example ACME Directory URL only shows the DV profile without noting other available Sectigo profiles (OV, EV, IV).
docs/documentation/platform/pki/ca/external-ca.mdx Minor update to add "Sectigo" to the list of ACME-compatible CAs and also corrects "Digicert" to the proper capitalization "DigiCert".
docs/docs.json Navigation entry for the new Sectigo page added in the correct position (after DigiCert, before Azure ADCS).

Last reviewed commit: 51f7ad3

@maidul98
Copy link
Collaborator

maidul98 commented Mar 4, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@carlosmonastyrski carlosmonastyrski merged commit cac43c0 into main Mar 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants