Skip to content

chore: remove frontend scim checks for user management#5575

Merged
x032205 merged 2 commits intomainfrom
misc/remove-frontend-scim-checks-for-user-management
Mar 3, 2026
Merged

chore: remove frontend scim checks for user management#5575
x032205 merged 2 commits intomainfrom
misc/remove-frontend-scim-checks-for-user-management

Conversation

@sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Mar 3, 2026

Context

This PR removes the unnecessary SCIM checks during user deletion at the organization level

Screenshots

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@sheensantoscapadngan sheensantoscapadngan changed the title misc: remove frontend scim checks for user management chore: remove frontend scim checks for user management Mar 3, 2026
@maidul98
Copy link
Collaborator

maidul98 commented Mar 3, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 3, 2026

Greptile Summary

This PR removes frontend-only SCIM guards that were previously blocking user deletion, deactivation, and activation at the organization level when currentOrg?.scimEnabled was true. The guards produced error notifications and returned early, preventing admins from managing users through Infisical's UI even when the backend may have permitted the operations.

Key changes:

  • OrgMembersSection.tsx: Removes the allowedLabel tooltip message and the currentOrg?.scimEnabled condition from the bulk-delete button's isDisabled prop.
  • OrgMembersTable.tsx: Removes two early-exit SCIM blocks from the per-row activate/deactivate and remove-user click handlers.
  • UserDetailsByIDPage.tsx: Removes two equivalent early-exit SCIM blocks from the user details page dropdown handlers.

No new logic is introduced, no imports are left dangling, and currentOrg remains in use in all three files for other purposes. The change is consistent and leaves authorization entirely to the permission system (OrgPermissionCan) and backend enforcement.

Confidence Score: 5/5

  • This PR is safe to merge — it is a pure removal of redundant frontend guards with no new logic introduced.
  • The changes are straightforward deletions of frontend early-exit checks. All three files remain logically consistent after the removal, no imports become unused, and authorization is still enforced by the existing OrgPermissionCan wrappers and backend layer. No security regressions are introduced.
  • No files require special attention.

Last reviewed commit: 97caf90

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 3, 2026

Additional Comments (1)

frontend/src/pages/organization/AccessManagementPage/components/OrgMembersTab/components/OrgMembersSection/OrgMembersTable.tsx, line 697
Inconsistent SCIM enforcement with bulk delete

This PR removes SCIM checks from the individual "Remove User" and "Activate/Deactivate User" buttons in OrgMembersTable.tsx and UserDetailsByIDPage.tsx, but OrgMembersSection.tsx (lines 183 and 201) still disables the bulk "Delete" button when currentOrg?.scimEnabled is true:

// OrgMembersSection.tsx — still present after this PR
isDisabled={!isAllowed || currentOrg?.scimEnabled}

This creates a confusing inconsistency: admins can remove individual members via the per-row dropdown even when SCIM is enabled, but the bulk-delete button remains blocked. If the intent is to lift SCIM restrictions on user management entirely, the bulk-delete guard in OrgMembersSection.tsx should also be removed. If the SCIM restriction is intentional for bulk operations, the same guard should be re-added to the individual actions.

@x032205
Copy link
Member

x032205 commented Mar 3, 2026

@greptile re-review this PR

@x032205 x032205 merged commit 0d0a4e3 into main Mar 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants