Skip to content

fix(frontend): display generate lease for totp dynamic secret on overview page#5523

Merged
varonix0 merged 1 commit intomainfrom
totp-dynamic-secret-lease
Feb 19, 2026
Merged

fix(frontend): display generate lease for totp dynamic secret on overview page#5523
varonix0 merged 1 commit intomainfrom
totp-dynamic-secret-lease

Conversation

@scott-ray-wilson
Copy link
Contributor

Context

This PR removes an incorrect if check that hide the generate lease button for TOTP dynamic secrets

Screenshots

CleanShot 2026-02-19 at 15 36 42@2x

Steps to verify the change

  • add totp dynamic secret and test issuance

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 19, 2026

Greptile Summary

Removed an incorrect conditional check (dynamicSecret.type !== DynamicSecretProviders.Totp) that was preventing the "Generate Lease" button from appearing for TOTP dynamic secrets in the overview page.

  • TOTP dynamic secrets fully support lease generation with auto-generation on modal open
  • The lease generation UI includes a special countdown timer display for TOTP codes
  • The same "Generate Lease" button appears for TOTP in the detailed list view (DynamicSecretListView.tsx), confirming this was a bug
  • This fix aligns the overview page behavior with the detail view behavior

Confidence Score: 5/5

  • This PR is safe to merge - it fixes a UI bug by removing an incorrect conditional check
  • The change is a simple bug fix that removes a conditional wrapper preventing the Generate Lease button from showing for TOTP secrets. Investigation confirms TOTP fully supports lease generation with dedicated UI components, and the same button already appears elsewhere for TOTP secrets. No security, logic, or breaking change concerns.
  • No files require special attention

Important Files Changed

Filename Overview
frontend/src/pages/secret-manager/OverviewPage/components/DynamicSecretTableRow/DynamicSecretTableRow.tsx Removed incorrect conditional check that was hiding the generate lease button for TOTP dynamic secrets

Last reviewed commit: 624f450

@varonix0 varonix0 merged commit 3a6cba5 into main Feb 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants