Skip to content

feat(frontend): migrate org MI page to v3 components#5513

Merged
scott-ray-wilson merged 7 commits intomainfrom
identity-memberships-page-v3
Feb 19, 2026
Merged

feat(frontend): migrate org MI page to v3 components#5513
scott-ray-wilson merged 7 commits intomainfrom
identity-memberships-page-v3

Conversation

@scott-ray-wilson
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson commented Feb 18, 2026

Context

This PR migrates the org machine identity page to v3 components and adjust v3 component styling

Screenshots

CleanShot 2026-02-18 at 13 56 54@2x

Steps to verify the change

verify all MI and auth template management functionality is preserved (both org and sub-org)
verify styling adjustment between org and sub-org display (green vs blue primary)
verify responsive behavior of new components (long names, truncation, etc.)
verify loading state display
verify permission guards still enforced

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

maidul98 commented Feb 18, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@scott-ray-wilson scott-ray-wilson changed the title Identity memberships page v3 feat(frontend): migrate org MI page to v3 components Feb 18, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 18, 2026

Greptile Summary

This PR migrates the org machine identity page and org members page from v2 components to v3 components (Card, Table, Dropdown, Input, Pagination, etc.) and switches from FontAwesome to Lucide icons. It also applies minor styling tweaks to shared v3 components (Card title layout, InputGroup icon color, Select truncation, Table header selection prevention).

  • Migrated IdentitySection, IdentityTable, IdentityAuthTemplatesTable to v3 Card/Table/Dropdown components
  • Migrated OrgMembersSection and OrgMembersTable to v3 components with consistent sub-org styling
  • Updated LastLoginSection to use Lucide icons and v3 design tokens
  • Added className prop passthrough to DocumentationLinkBadge
  • The distinct "feature not activated" empty state for unlicensed auth templates was lost in the migration — users without the feature now see a generic "no templates" message
  • Filter label in IdentityTable is hardcoded and doesn't adapt for sub-organizations unlike the equivalent in OrgMembersTable

Confidence Score: 4/5

  • This PR is a frontend-only UI component migration with low risk to core functionality.
  • The changes are purely presentational — migrating from v2 to v3 UI components and switching icon libraries. No backend, API, or security-sensitive logic is affected. Two minor issues were found: a lost license-gated empty state and a hardcoded filter label that doesn't adapt for sub-organizations.
  • IdentityAuthTemplatesTable.tsx (lost license-gated empty state) and IdentityTable.tsx (hardcoded filter label)

Important Files Changed

Filename Overview
frontend/src/pages/organization/AccessManagementPage/components/OrgIdentityTab/components/IdentitySection/IdentityAuthTemplatesTable.tsx Migrated to v3 components. The distinct "feature not activated" empty state for unlicensed subscriptions was lost — users without the feature now see a misleading generic empty message.
frontend/src/pages/organization/AccessManagementPage/components/OrgIdentityTab/components/IdentitySection/IdentitySection.tsx Migrated to v3 Card components. Button aliased as ButtonV2 for the wizard step toggle that still uses v2. Clean migration with no issues.
frontend/src/pages/organization/AccessManagementPage/components/OrgIdentityTab/components/IdentitySection/IdentityTable.tsx Migrated to v3 table, dropdown, and input components. Filter label is hardcoded to "Organization Role" and doesn't adapt for sub-organizations unlike the analogous OrgMembersTable.
frontend/src/pages/organization/AccessManagementPage/components/OrgMembersTab/components/OrgMembersSection/OrgMembersSection.tsx Migrated to v3 Card and Button components. Selection bar and modals restructured cleanly. No issues found.
frontend/src/pages/organization/AccessManagementPage/components/OrgMembersTab/components/OrgMembersSection/OrgMembersTable.tsx Migrated to v3 components. Clean migration with consistent sub-org awareness. No issues found.

Last reviewed commit: 1d66ac0

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

11 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@IgorHorta IgorHorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scott-ray-wilson scott-ray-wilson merged commit ede54ff into main Feb 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants