Skip to content

docs(python): add LDAP authentication method to Python SDK documentation#5511

Merged
victorvhs017 merged 2 commits intomainfrom
doos/python-ldap-auth
Feb 18, 2026
Merged

docs(python): add LDAP authentication method to Python SDK documentation#5511
victorvhs017 merged 2 commits intomainfrom
doos/python-ldap-auth

Conversation

@victorvhs017
Copy link
Contributor

Context

Updated the Python SDK documentation with LDAP auth.

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

maidul98 commented Feb 18, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 18, 2026

Greptile Summary

This PR adds LDAP authentication method documentation to the Python SDK page, including a code example, parameter descriptions, and a brief explanation. The new section is consistent with LDAP auth documentation already present in the Go, Java, and .NET SDK docs.

  • Adds client.auth.ldap_auth.login() usage example with identity_id, username, and password parameters
  • Section is correctly placed between OIDC Auth and Token Auth
  • Minor suggestion: add an <Info> admonition linking to the LDAP auth platform docs for consistency with the Go SDK documentation

Confidence Score: 4/5

  • This PR is safe to merge — it only adds documentation content with no code changes.
  • Documentation-only change that follows existing patterns. The LDAP auth section is consistent with other SDK docs. One minor style suggestion for adding an info admonition. No risk of breaking anything.
  • No files require special attention.

Important Files Changed

Filename Overview
docs/sdks/languages/python.mdx Adds LDAP auth section with code example and parameter documentation. Content is consistent with other SDK docs (Go, Java, .NET). Missing an info admonition linking to the LDAP auth platform docs that other SDKs include.

Last reviewed commit: 72bfd1f

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@victorvhs017 victorvhs017 merged commit d82752a into main Feb 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants