Skip to content

fix: sendApprovalEmailsFn wrong end of url symbol#5506

Merged
carlosmonastyrski merged 1 commit intomainfrom
fix/secretApprovalsEmailLink
Feb 17, 2026
Merged

fix: sendApprovalEmailsFn wrong end of url symbol#5506
carlosmonastyrski merged 1 commit intomainfrom
fix/secretApprovalsEmailLink

Conversation

@carlosmonastyrski
Copy link
Contributor

Context

Removed wrong end of url symbol "}" on sendApprovalEmailsFn causing issues on redirection

Screenshots

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 17, 2026

Greptile Summary

This PR fixes a bug in sendApprovalEmailsFn where a stray } character was appended to the approval URL in secret approval request emails. The malformed URL (ending in /approval} instead of /approval) would cause broken redirects when reviewers clicked the email link.

  • Removed the extraneous } from the approvalUrl template string on line 54 of secret-approval-request-fns.ts
  • The fix aligns this URL with the notification link on line 40 of the same file and with other approval URL constructions throughout the codebase (e.g., secret-approval-request-service.ts:1218)

Confidence Score: 5/5

  • This PR is a safe, minimal one-character bug fix with no risk of regressions.
  • The change is a single-character removal of a stray } from a URL string. It is clearly a bug fix — the corrected URL matches the identical pattern used elsewhere in the same file (line 40) and across the codebase. There are no logic changes, no new code paths, and no security implications.
  • No files require special attention.

Important Files Changed

Filename Overview
backend/src/ee/services/secret-approval-request/secret-approval-request-fns.ts Removes a stray } character from the approval URL in sendApprovalEmailsFn, fixing broken email redirect links. The fix is consistent with the notification link on line 40 and other approval URL patterns in the codebase.

Last reviewed commit: 4db6860

@carlosmonastyrski carlosmonastyrski merged commit 4143b75 into main Feb 17, 2026
7 of 9 checks passed
@maidul98
Copy link
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants