chore: add support for PKI DNS CNAME delegation#5501
Merged
carlosmonastyrski merged 4 commits intomainfrom Feb 17, 2026
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Greptile SummaryAdded DNS CNAME delegation support for ACME DNS-01 challenges, allowing
The change follows RFC 8555 standard ACME CNAME delegation pattern used by certbot and acme.sh. Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 285ccfc |
backend/src/services/certificate-authority/acme/acme-certificate-authority-fns.ts
Show resolved
Hide resolved
backend/src/services/certificate-authority/acme/acme-certificate-authority-fns.ts
Show resolved
Hide resolved
Contributor
Author
|
@greptile, with the responses to your comments and my latest changes in mind, re-review my PR and update your summary when you are done. |
backend/src/services/certificate-authority/acme/acme-certificate-authority-fns.ts
Show resolved
Hide resolved
backend/src/services/certificate-authority/acme/acme-certificate-authority-fns.ts
Outdated
Show resolved
Hide resolved
sheensantoscapadngan
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Improve External CAs order flow to support DNS CNAME delegation, meaning a domain can have a CNAME record pointing to another domain, making all TXT writing attempts fall into that second one instead of itself.
Screenshots
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).