Skip to content

fix: remove extra vault migration validation#5499

Merged
varonix0 merged 3 commits intomainfrom
daniel/remove-vault-path-validation
Feb 16, 2026
Merged

fix: remove extra vault migration validation#5499
varonix0 merged 3 commits intomainfrom
daniel/remove-vault-path-validation

Conversation

@varonix0
Copy link
Member

Context

Removed the recursive function for listing vault kv secret paths. This validation function already takes a long time and actually times out for folks with a lot of nested secret paths.

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

maidul98 commented Feb 16, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 16, 2026

Greptile Summary

Removed the recursive call to listHCVaultSecretPaths during validation to prevent timeouts for users with deeply nested secret paths. The validation now only calls listHCVaultMounts without recursively traversing secret paths.

  • Fixed timeout issue for users with many nested secret paths
  • Removed unnecessary recursive validation during connection setup
  • Found typo: 'confiugration' should be 'configuration' (line 353)

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change removes an expensive recursive validation call that was causing timeouts without affecting security or functionality. The validation still checks policies and auth mounts, which are sufficient for verifying connection validity. The removed operation was purely for listing secret paths and doesn't impact the actual migration process.
  • No files require special attention

Important Files Changed

Filename Overview
backend/src/services/external-migration/external-migration-service.ts Removed recursive validation call for listing vault KV secret paths during connection validation to fix timeout issues with deeply nested secret paths

Last reviewed commit: 50098eb

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

varonix0 and others added 2 commits February 17, 2026 00:13
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@varonix0 varonix0 merged commit f44b2df into main Feb 16, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants