Skip to content

feat(overview): add commit history access to overview page#5484

Merged
scott-ray-wilson merged 1 commit intomainfrom
SECRETS-88
Feb 16, 2026
Merged

feat(overview): add commit history access to overview page#5484
scott-ray-wilson merged 1 commit intomainfrom
SECRETS-88

Conversation

@scott-ray-wilson
Copy link
Contributor

Context

This PR adds commit history access to the overview page, improves responsiveness and updates the back link on the commit page to navigate to the overview page

Screenshots

CleanShot 2026-02-13 at 20 24 27@2x CleanShot 2026-02-13 at 20 24 12@2x

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@linear
Copy link

linear bot commented Feb 14, 2026

@maidul98
Copy link
Collaborator

maidul98 commented Feb 14, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 14, 2026

Greptile Overview

Greptile Summary

This PR adds commit history access to the overview page with a badge showing commit count when viewing a single environment. Users can click to navigate to the commits page from both the environment dropdown menu (multi-env view) and the commit badge (single-env view). The back link on the commits page now navigates to the overview page instead of the old secrets page.

Key Changes:

  • Added commit history navigation with handleViewCommitHistory that fetches folder ID and navigates to commits page
  • Implemented environment selection persistence using localStorage (overview-selected-envs-${projectId})
  • Added DownloadEnvButton component for downloading .env files (single environment only)
  • Enhanced dynamic secret and folder rows with delete functionality
  • Improved responsive layout across multiple table row components
  • Updated route schema to support environments array parameter for URL state

Implementation Quality:

  • Proper permission checks using canReadCommits before allowing commit history access
  • Upgrade prompt shown when pitRecovery subscription feature is not available
  • Download functionality correctly merges local and imported secrets with personal overrides taking precedence
  • Value escaping in download helper properly handles backslashes and quotes

Confidence Score: 4/5

  • Safe to merge with minor considerations around documentation
  • The implementation is solid with proper permission checks, error handling, and escaping. The code follows React best practices with hooks like useMemo and useCallback. However, the PR introduces significant new user-facing features without documentation updates (download button, commit history access), which may impact feature discoverability per custom rule guidelines.
  • No files require special attention - all changes are well-structured frontend enhancements with appropriate safeguards

Important Files Changed

Filename Overview
frontend/src/helpers/download.ts Added downloadSecretEnvFile function to merge and format secrets for .env file download with proper escaping
frontend/src/pages/secret-manager/OverviewPage/OverviewPage.tsx Major refactor: added commit history navigation, download env button, environment persistence in localStorage, folder/dynamic secret deletion, and improved responsiveness
frontend/src/pages/secret-manager/OverviewPage/components/DownloadEnvButton/DownloadEnvButton.tsx New component for downloading environment secrets, only enabled for single environment selection with proper permission checks
frontend/src/pages/secret-manager/CommitsPage/CommitsPage.tsx Updated back link to navigate to overview page with environment selection instead of old secrets page
frontend/src/pages/secret-manager/OverviewPage/components/DynamicSecretTableRow/DynamicSecretTableRow.tsx Enhanced with edit, delete, and lease management functionality for dynamic secrets across environments

Last reviewed commit: 6f8fa4f

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@scott-ray-wilson scott-ray-wilson merged commit 8e3855f into main Feb 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants