Skip to content

improvement(api): update local dev env to use infisical for the db name and credentials#5462

Merged
fangpenlin merged 1 commit intomainfrom
ENG-4567-provide-clickhouse-db-name
Feb 12, 2026
Merged

improvement(api): update local dev env to use infisical for the db name and credentials#5462
fangpenlin merged 1 commit intomainfrom
ENG-4567-provide-clickhouse-db-name

Conversation

@fangpenlin
Copy link
Contributor

Context

ref: https://linear.app/infisical/issue/ENG-4567/update-infisical-platform-backend-code-to-allow-sending-audit-logs-to

Screenshots

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@linear
Copy link

linear bot commented Feb 12, 2026

@fangpenlin fangpenlin marked this pull request as ready for review February 12, 2026 01:44
@gitguardian
Copy link

gitguardian bot commented Feb 12, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9387833 Triggered Generic Password bf6b2aa docker-compose.dev.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@maidul98
Copy link
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

Updated local development environment configuration to use consistent infisical credentials across ClickHouse setup instead of the default default/clickhouse credentials. This change affects:

  • Environment variable examples for ClickHouse connection URLs
  • Docker Compose ClickHouse service configuration
  • Logger dependency injection improvement in ClickHouse migration runner

The changes standardize naming conventions across the development environment and improve code maintainability by passing the logger as a parameter instead of importing it globally.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are configuration updates for local development environment. The credential changes are consistent across all files, and the logger refactoring improves code quality without changing functionality. No security issues or breaking changes detected.
  • No files require special attention

Important Files Changed

Filename Overview
.env.example Updated ClickHouse URL to use infisical credentials and database name instead of default/clickhouse
.env.migration.example Updated ClickHouse URL to use infisical credentials and database name instead of default/clickhouse
backend/src/auto-start-migrations.ts Added logger parameter to ensureClickHouseSchema call for better dependency injection
backend/src/db/clickhouse-migration-runner.ts Refactored to accept logger as parameter instead of importing global logger, improving testability
backend/src/db/run-clickhouse-migrations.ts Initialized logger and passed it to ensureClickHouseSchema for consistent logging
backend/src/lib/config/env.ts Updated ClickHouse URL description to use database instead of default for clarity
docker-compose.dev.yml Changed ClickHouse environment variables to use infisical instead of default/clickhouse for consistency

@fangpenlin fangpenlin requested a review from maidul98 February 12, 2026 01:48
@fangpenlin fangpenlin merged commit b3ac903 into main Feb 12, 2026
10 of 11 checks passed
@fangpenlin fangpenlin deleted the ENG-4567-provide-clickhouse-db-name branch February 12, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants