You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
following these best practices for managing and storing secrets including API keys and other credentials
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Updated local development environment configuration to use consistent infisical credentials across ClickHouse setup instead of the default default/clickhouse credentials. This change affects:
Environment variable examples for ClickHouse connection URLs
Docker Compose ClickHouse service configuration
Logger dependency injection improvement in ClickHouse migration runner
The changes standardize naming conventions across the development environment and improve code maintainability by passing the logger as a parameter instead of importing it globally.
Confidence Score: 5/5
This PR is safe to merge with minimal risk
All changes are configuration updates for local development environment. The credential changes are consistent across all files, and the logger refactoring improves code quality without changing functionality. No security issues or breaking changes detected.
No files require special attention
Important Files Changed
Filename
Overview
.env.example
Updated ClickHouse URL to use infisical credentials and database name instead of default/clickhouse
.env.migration.example
Updated ClickHouse URL to use infisical credentials and database name instead of default/clickhouse
backend/src/auto-start-migrations.ts
Added logger parameter to ensureClickHouseSchema call for better dependency injection
backend/src/db/clickhouse-migration-runner.ts
Refactored to accept logger as parameter instead of importing global logger, improving testability
backend/src/db/run-clickhouse-migrations.ts
Initialized logger and passed it to ensureClickHouseSchema for consistent logging
backend/src/lib/config/env.ts
Updated ClickHouse URL description to use database instead of default for clarity
docker-compose.dev.yml
Changed ClickHouse environment variables to use infisical instead of default/clickhouse for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
ref: https://linear.app/infisical/issue/ENG-4567/update-infisical-platform-backend-code-to-allow-sending-audit-logs-to
Screenshots
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).