Skip to content

chore: removed lint stage check#5434

Merged
akhilmhdh merged 1 commit intomainfrom
chore/lint-stage
Feb 12, 2026
Merged

chore: removed lint stage check#5434
akhilmhdh merged 1 commit intomainfrom
chore/lint-stage

Conversation

@akhilmhdh
Copy link
Member

Context

This PR removes the lint stage check that run backend and frontend type check and lint. This is making each commit takes longer to run.

We have a PR workflow that ensures all PRs have both ts and lint errors fixed.

Screenshots

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@akhilmhdh akhilmhdh requested a review from IgorHorta February 11, 2026 15:04
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 11, 2026

Greptile Overview

Greptile Summary

This change removes lint-staged from the pre-commit hook and deletes the root lint-staged configuration (and Husky dependency) to speed up local commits. The remaining pre-commit behavior is limited to infisical scan git-changes --staged -v.

Main concern: Husky installation appears to be removed (prepare: husky install + husky devDependency) while .husky/pre-commit remains tracked. If there isn’t another installation mechanism in the repo, developers will silently lose the pre-commit hook on fresh installs/clones.

Also, the lockfile contains unrelated metadata churn (peer flags) beyond removing Husky, suggesting it may have been regenerated rather than minimally updated.

Confidence Score: 3/5

  • This PR is generally low-risk but may unintentionally disable local pre-commit hooks for fresh installs.
  • Changes are confined to tooling, but removing Husky installation while keeping a Husky hook file will cause the hook to stop running unless another install mechanism exists. Lockfile churn also increases the chance of accidental dependency metadata drift.
  • package.json, .husky/pre-commit, package-lock.json

Important Files Changed

Filename Overview
.husky/pre-commit Removes npx lint-staged from the pre-commit hook, leaving only infisical scan git-changes --staged -v.
package.json Removes Husky prepare script and the root lint-staged config; devDependency on husky is removed, leaving scripts as an empty object.
package-lock.json Removes Husky from lockfile but also changes dependency metadata (adds/removes peer flags) for unrelated packages, indicating the lockfile may have been regenerated rather than minimally updated.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@maidul98
Copy link
Collaborator

maidul98 commented Feb 11, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Contributor

@IgorHorta IgorHorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akhilmhdh looks good!
I would just remove the .husky/pre-commit if its not being used at all without the preapre

IgorHorta
IgorHorta previously approved these changes Feb 11, 2026
Copy link
Contributor

@IgorHorta IgorHorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Infisical Infisical deleted a comment from IgorHorta Feb 12, 2026
@akhilmhdh akhilmhdh merged commit 769d59c into main Feb 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants