Skip to content

feat(frontend): add secret share action to overview page#5426

Merged
scott-ray-wilson merged 4 commits intomainfrom
SECRETS-121
Feb 12, 2026
Merged

feat(frontend): add secret share action to overview page#5426
scott-ray-wilson merged 4 commits intomainfrom
SECRETS-121

Conversation

@scott-ray-wilson
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson commented Feb 10, 2026

Context

This PR adds our share secret modal to the overview page, moves secret references to the dropdown menu, and adds icon button open state styling

Screenshots

CleanShot 2026-02-10 at 14 53 04@2x

Steps to verify the change

  • Verify you can share secret
  • verify button state enabled / disabled in appropriate contexts (ie only if you can read value)
  • verify secret references still works :pepeok

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@linear
Copy link

linear bot commented Feb 10, 2026

SECRETS-121 Add secret share to overview

@maidul98
Copy link
Collaborator

maidul98 commented Feb 10, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@scott-ray-wilson scott-ray-wilson marked this pull request as ready for review February 12, 2026 02:11
@scott-ray-wilson
Copy link
Contributor Author

scott-ray-wilson commented Feb 12, 2026

@greptile review this

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

This PR adds secret sharing functionality to the overview page by integrating the AddShareSecretModal component and reorganizing the UI. The secret reference viewer has been moved from a standalone icon button to the dropdown menu for better organization, and a new share secret button with a ForwardIcon has been added. Additionally, icon buttons now receive visual feedback when their associated dropdowns are open via the data-[state=open]:bg-foreground/5 styling.

Key changes:

  • Added share secret action button that opens the secret sharing modal
  • Moved secret references option to the dropdown menu for cleaner UI
  • Added visual state indicator for open dropdowns/popovers on icon buttons
  • Proper permission checks ensure share button is only enabled when user can read the secret value and secret sharing is enabled for the project

The implementation follows existing patterns, maintains proper permission checks, and the feature is already documented in /docs/documentation/platform/secret-sharing.mdx.

Confidence Score: 5/5

  • This PR is safe to merge with no identified issues
  • The changes are purely frontend UI enhancements that integrate an existing modal component, add styling for better UX, and reorganize buttons. No security vulnerabilities, breaking changes, or logical errors were found. The implementation follows existing patterns, includes proper permission checks, and the feature is already documented.
  • No files require special attention

Important Files Changed

Filename Overview
frontend/src/components/v3/generic/IconButton/IconButton.tsx Added data-[state=open]:bg-foreground/5 styling to highlight icon buttons when their associated dropdown/popover is open
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx Added share secret button to overview page, moved secret references from standalone button to dropdown menu, and integrated AddShareSecretModal component

IgorHorta
IgorHorta previously approved these changes Feb 12, 2026
View reviewed changes
IgorHorta
IgorHorta approved these changes Feb 12, 2026
View reviewed changes
Copy link
Contributor

@IgorHorta IgorHorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scott-ray-wilson scott-ray-wilson merged commit 2951f24 into main Feb 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IgorHorta IgorHorta IgorHorta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scott-ray-wilson @maidul98 @IgorHorta