Skip to content

fix: address pam account mutation response issue#5421

Merged
sheensantoscapadngan merged 1 commit intomainfrom
fix/address-pam-account-mutation-response-issues
Feb 10, 2026
Merged

fix: address pam account mutation response issue#5421
sheensantoscapadngan merged 1 commit intomainfrom
fix/address-pam-account-mutation-response-issues

Conversation

@sheensantoscapadngan
Copy link
Member

Context

Screenshots

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR fixes a response inconsistency in the PAM account service. The updateById and deleteById functions now consistently include the resourceType field at the top level of their response objects, matching the structure returned by the create function and other account operations.

Changes:

  • Added resourceType: resource.resourceType to the response object in updateById function (both successful update and early return cases)
  • Added resourceType: resource.resourceType to the response object in deleteById function

This ensures API consumers receive a consistent response shape across all PAM account mutation operations, preventing potential client-side errors when processing the response.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are minimal and purely additive, adding a missing field to response objects to ensure consistency across API endpoints. No logic changes, no security implications, and the fix aligns perfectly with existing patterns in the codebase.
  • No files require special attention

Important Files Changed

Filename Overview
backend/src/ee/services/pam-account/pam-account-service.ts Added resourceType field to response objects in updateById and deleteById functions to fix inconsistent response structure

@sheensantoscapadngan sheensantoscapadngan merged commit 7adfc95 into main Feb 10, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants