You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a error log to debug the app connection failing reason for hashicloud app connection
Screenshots
Steps to verify the change
Type
Fix
Feature
Improvement
Breaking
Docs
Chore
Checklist
Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
This PR adds a single error log in getHCVaultAccessToken’s catch block to help debug failures when validating HashiCorp Vault AppRole-based app connections.
The change is localized to the HC Vault app-connection helpers in backend/src/services/app-connection/hc-vault/hc-vault-connection-fns.ts, which are used during connection validation and when making Vault API calls (optionally via the gateway proxy).
Confidence Score: 4/5
Mostly safe to merge, but current logging change can leak sensitive Vault credentials into logs.
Change is small and improves observability, but logging the raw error object during credential validation can include Axios request config/headers and may persist secrets (tokens/namespace) in centralized logs; this should be sanitized before merge.
Added an error log in getHCVaultAccessToken() catch block to help debug AppRole connection failures; verify logging does not leak sensitive Axios/request details.
This PR adds a single error log in getHCVaultAccessToken’s catch block to help debug failures when validating HashiCorp Vault AppRole-based app connections.
The change is localized to the HC Vault app-connection helpers in backend/src/services/app-connection/hc-vault/hc-vault-connection-fns.ts, which are used during connection validation and when making Vault API calls (optionally via the gateway proxy).
Confidence Score: 4/5
Mostly safe to merge, but current logging change can leak sensitive Vault credentials into logs.
Change is small and improves observability, but logging the raw error object during credential validation can include Axios request config/headers and may persist secrets (tokens/namespace) in centralized logs; this should be sanitized before merge.
Added an error log in getHCVaultAccessToken() catch block to help debug AppRole connection failures; verify logging does not leak sensitive Axios/request details.
This PR adds a single error log in getHCVaultAccessToken’s catch block to help debug failures when validating HashiCorp Vault AppRole-based app connections.
The change is localized to the HC Vault app-connection helpers in backend/src/services/app-connection/hc-vault/hc-vault-connection-fns.ts, which are used during connection validation and when making Vault API calls (optionally via the gateway proxy).
Confidence Score: 4/5
Mostly safe to merge, but current logging change can leak sensitive Vault credentials into logs.
Change is small and improves observability, but logging the raw error object during credential validation can include Axios request config/headers and may persist secrets (tokens/namespace) in centralized logs; this should be sanitized before merge.
Added an error log in getHCVaultAccessToken() catch block to help debug AppRole connection failures; verify logging does not leak sensitive Axios/request details.
This PR adds a single error log in getHCVaultAccessToken’s catch block to help debug failures when validating HashiCorp Vault AppRole-based app connections.
The change is localized to the HC Vault app-connection helpers in backend/src/services/app-connection/hc-vault/hc-vault-connection-fns.ts, which are used during connection validation and when making Vault API calls (optionally via the gateway proxy).
Confidence Score: 4/5
Mostly safe to merge, but current logging change can leak sensitive Vault credentials into logs.
Change is small and improves observability, but logging the raw error object during credential validation can include Axios request config/headers and may persist secrets (tokens/namespace) in centralized logs; this should be sanitized before merge.
Added an error log in getHCVaultAccessToken() catch block to help debug AppRole connection failures; verify logging does not leak sensitive Axios/request details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR adds a error log to debug the app connection failing reason for hashicloud app connection
Screenshots
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).