fix: resolved failing enotfound error in hcp vault app connection#5394
Merged
fix: resolved failing enotfound error in hcp vault app connection#5394
Conversation
Removed redundant calls to blockLocalAndPrivateIpAddresses in getHCVaultInstanceUrl and getHCVaultConnectionListItem functions.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Greptile OverviewGreptile SummaryFixed ENOTFOUND error when using HCP Vault app connections with a gateway by correctly passing the gateway flag to Changes made:
The fix correctly addresses the root cause where DNS resolution was failing for internal hosts that should only be accessed via gateway. Confidence Score: 4/5
Important Files Changed
|
varonix0
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes ENOTFOUND error with gateway usage ofr hcp vault app connection. This was because the gateway boolean flag was not getting passed to the function.
Removed check
blockLocalAndPrivateIpAddressesfrom getInstanceURl` as it's already done in main request functionScreenshots
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).