feat: implement durable queue for redis queues that needs persistence in PG#5380
feat: implement durable queue for redis queues that needs persistence in PG#5380
Conversation
Greptile OverviewGreptile SummaryThis PR implements Postgres-backed recovery for Redis queues, migrating away from pg-boss to pure BullMQ with a persistence layer. The implementation adds a Key Changes:
Architecture: Issues Found:
Confidence Score: 4/5
Important Files Changed
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
fangpenlin
left a comment
There was a problem hiding this comment.
I don't have a chance to carefully running it locally yet, but would like to provide some feedbacks / questions from my preliminary review.
backend/src/ee/services/secret-rotation/secret-rotation-queue/secret-rotation-queue.ts
Show resolved
Hide resolved
bd4fa28 to
326f387
Compare
326f387 to
3787876
Compare
Context
This PR implements postgres backup and recovery for redis queues that needs persistence over wipe out. Some queues that need are
This PR completely removes pg_boss dependency usage and migrated back to redis queue.
There is two new queue jobs
All the bullmq cron job has a key parameter. This ensure we alter the timing window later.
Screenshots
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).