Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile OverviewGreptile SummaryFixed validation error when renaming newly created secrets by addressing Root cause: Newly created secrets could have Solution implemented:
Additional changes: Fixed grammar in error message "Shared secret value too long" → "Shared secret value is too long" The fix maintains backward compatibility while preventing the validation error. PATCH endpoints remain strict (boolean/undefined only), while CREATE endpoints are more lenient (null → false). Confidence Score: 5/5
Important Files Changed
|
scott-ray-wilson
left a comment
There was a problem hiding this comment.
LGTM, tested with and without approvals
Context
Fixes validation error when renaming a secret: API expected
booleanforskipMultilineEncodingbut receivednull(e.g. from newly created secrets), causing "expected boolean, received null". Rename was sending the full secret payload including that field.nullforskipMultilineEncoding.newSecretName. CREATE accepts null and coerces tofalse; PATCH stays strict (reject null). New secrets never persistnullforskipMultilineEncoding.Also: copy fix "Shared secret value too long" → "Shared secret value is too long"; added missing
orgGroupMembership/types.tsfor pre-commit/ESLint.Screenshots
N/A
Steps to verify the change
Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).