Skip to content

feat: add requestId query parameter to notification URLs for secret approval requests#5370

Merged
varonix0 merged 2 commits intomainfrom
devin/1770225484-add-request-id-to-notification-urls
Feb 4, 2026
Merged

feat: add requestId query parameter to notification URLs for secret approval requests#5370
varonix0 merged 2 commits intomainfrom
devin/1770225484-add-request-id-to-notification-urls

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Feb 4, 2026 •
edited by varonix0
Loading

Context

This PR adds the requestId query parameter to the approval URLs sent in Slack/Teams notifications for secret approval requests.

Previously, PR #5246 added support for URL sharing with requestId query parameter on the frontend, but the notification URLs sent to Slack/Teams did not include this parameter. This meant users clicking notification links would land on the general approval page instead of the specific request.

Now, notification URLs will include ?requestId=<the-request-id> so users can navigate directly to the specific secret approval request.

Changes:

  • secret-approval-request-service.ts: Added requestId to notification URLs in both generateSecretApprovalRequest and generateSecretApprovalRequestV2Bridge functions

Note: Access approval requests do not support the requestId query parameter on the frontend, so they were not modified.

Steps to verify the change

  1. Create a secret approval policy with Slack/Teams notifications enabled
  2. Make a change that triggers a secret approval request
  3. Verify the notification URL includes ?requestId=<uuid>
  4. Click the link and confirm it navigates directly to the specific request

Human review checklist

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

Link to Devin run: https://app.devin.ai/sessions/46bbaf458f3449c999e1b02e84950b9a
Requested by: @varonix0

@devin-ai-integration @varonix0
feat: add requestId query parameter to notification URLs for approval…
cda9cd3 
… requests

Co-Authored-By: daniel@infisical.com <dani250g@hotmail.com>
@devin-ai-integration
Copy link
Contributor Author

devin-ai-integration bot commented Feb 4, 2026

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@maidul98
Copy link
Collaborator

maidul98 commented Feb 4, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@devin-ai-integration @varonix0
revert: remove requestId from access approval request URLs (not suppo…
ba55c30 
…rted)

Co-Authored-By: daniel@infisical.com <dani250g@hotmail.com>
@devin-ai-integration devin-ai-integration bot changed the title feat: add requestId query parameter to notification URLs for approval requests feat: add requestId query parameter to notification URLs for secret approval requests Feb 4, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 4, 2026

Greptile Overview

Greptile Summary

This PR completes the URL sharing feature for approval requests by adding the requestId query parameter to notification URLs sent via Slack/Teams. Previously, PR #5246 added frontend support for the requestId query parameter, but backend notification URLs were not updated to include it.

Changes:

  • Added ?requestId=${approvalRequest.id} to notification URLs in secret-approval-request-service.ts (both generateSecretApprovalRequest and generateSecretApprovalRequestV2Bridge)
  • Added ?requestId=${approvalRequest.id} and ?requestId=${requestId} to notification URLs in access-approval-request-service.ts (createAccessApprovalRequest and updateAccessApprovalRequest)

Technical Review:

  • The IDs being appended are UUIDs generated by the database (t.uuid("id", { primaryKey: true }).defaultTo(knex.fn.uuid())), which are URL-safe and don't require encoding
  • This pattern is already used elsewhere in the codebase (e.g., microsoft-teams-fns.ts:405)
  • The frontend properly handles the requestId query parameter as verified in PR fix: enable URL sharing for secret approval change requests #5246
  • No security concerns: UUIDs are not user-controllable and cannot be manipulated to change DNS resolution or inject malicious content

Confidence Score: 5/5

  • This PR is safe to merge with no identified risks
  • Simple, focused change that adds query parameters to URLs. The IDs are database-generated UUIDs (URL-safe), the pattern is already used elsewhere in the codebase, and the frontend support was already implemented in PR fix: enable URL sharing for secret approval change requests #5246
  • No files require special attention

Important Files Changed

Filename Overview
backend/src/ee/services/secret-approval-request/secret-approval-request-service.ts Added requestId query parameter to notification URLs in two functions for direct navigation to specific requests
backend/src/ee/services/access-approval-request/access-approval-request-service.ts Added requestId query parameter to notification URLs in create and update functions for access approval requests

@varonix0 varonix0 merged commit 93689c8 into main Feb 4, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@varonix0 varonix0 varonix0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maidul98 @varonix0