Skip to content

feat(frontend): secret version history on overview page#5363

Merged
scott-ray-wilson merged 7 commits intomainfrom
SECRETS-80
Feb 5, 2026
Merged

feat(frontend): secret version history on overview page#5363
scott-ray-wilson merged 7 commits intomainfrom
SECRETS-80

Conversation

@scott-ray-wilson
Copy link
Contributor

Context

This PR adds secret version history auditing and rollback to the overview page including new v3 components.

Also includes a fix for group member search that prevented searching by email

Screenshots

CleanShot 2026-02-03 at 17 54 07@2x

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@linear
Copy link

linear bot commented Feb 4, 2026

@maidul98
Copy link
Collaborator

maidul98 commented Feb 4, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 4, 2026

Greptile Overview

Greptile Summary

This PR adds secret version history auditing and rollback functionality to the overview page. Users can now view a timeline of all secret versions, see who modified each version, and restore previous versions. The PR also fixes a bug in group member search that prevented searching by email.

Key Changes:

  • Added new SecretVersionHistory component with timeline UI showing version history
  • Integrated version history into secret row dropdown menu alongside delete action
  • Created new v3 AlertDialog component for restoration confirmations
  • Fixed backend validation to allow . and @ characters in group member search (enables email search)
  • Enhanced v3 components (Item, Sheet, Empty) with improved styling and UX

Backend Fix:
The group member search validation was updated to include Period and At character types, enabling email-based searches. However, the error messages still reference the old allowed character set.

Frontend Implementation:
The version history feature uses the existing secret version API and integrates cleanly with the permission system. Version restoration creates a new secret update (or change request if approvals are required), maintaining audit trail integrity.

Confidence Score: 4/5

  • Safe to merge with minor error message corrections needed
  • The implementation is solid with proper permission checks and good UX. Two error messages need updating to match the new validation rules, and some logging could follow the repository's pattern better. No security issues or breaking changes detected.
  • backend/src/ee/routes/v1/group-router.ts needs error message updates to match validation changes

Important Files Changed

Filename Overview
backend/src/ee/routes/v1/group-router.ts Added Period and At character types to search validation for email support
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx Replaced trash button with dropdown menu containing version history and delete options
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretVersionHistory.tsx New component for viewing and restoring secret version history with timeline UI

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 5 comments

Edit Code Review Agent Settings | Greptile

scott-ray-wilson and others added 5 commits February 4, 2026 13:32
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@scott-ray-wilson scott-ray-wilson merged commit fd8299f into main Feb 5, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants