Skip to content

feature(frontend): toggle multi-line encoding from overview page#5338

Merged
scott-ray-wilson merged 1 commit intomainfrom
SECRETS-82
Feb 3, 2026
Merged

feature(frontend): toggle multi-line encoding from overview page#5338
scott-ray-wilson merged 1 commit intomainfrom
SECRETS-82

Conversation

@scott-ray-wilson
Copy link
Contributor

Context

This PR adds the ability to view and toggle multiline encoding from the overview page

Screenshots

CleanShot 2026-01-31 at 18 58 06@2x

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

maidul98 commented Feb 1, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 1, 2026

Greptile Overview

Greptile Summary

This PR adds the ability to toggle multiline encoding directly from the secret overview page, along with UI for managing tags and metadata.

Key Changes:

  • Added multiline encoding toggle button with WrapTextIcon that calls updateSecretV3 API to toggle skipMultilineEncoding
  • Created new SecretMetadataForm component for viewing/editing secret metadata with encryption toggle
  • Created new SecretTagForm component for managing secret tags with multi-select dropdown
  • Added new reusable UI components: Switch, Field, Label, and CreatableSelect to support the new forms
  • Extended type definitions to include optional isEncrypted field in secretMetadata

Implementation Details:

  • All three new action buttons (multiline, tags, metadata) appear on hover or when any popover is open
  • Proper permission checks are in place for all operations
  • Disabled states handle imported secrets, overrides, and permission restrictions
  • Backend already supports the isEncrypted metadata field (confirmed via grep of backend code)

Confidence Score: 5/5

  • This PR is safe to merge - adds new UI features with proper permission checks and no breaking changes
  • All changes are frontend-only UI enhancements that integrate well with existing backend APIs. The code follows established patterns, includes proper permission checks, and handles edge cases (imported secrets, overrides, etc.). The backend already supports the isEncrypted field.
  • No files require special attention

Important Files Changed

Filename Overview
frontend/src/hooks/api/secrets/types.ts Added optional isEncrypted boolean field to secretMetadata type for both SecretV3Raw and TUpdateSecretsV3DTO
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx Added multiline encoding toggle button, tag management popover, and metadata management popover to secret row actions
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretMetadataForm.tsx New form component for managing secret metadata with key-value pairs and encryption toggle
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTagForm.tsx New form component for managing secret tags with multi-select and tag creation capability

Copy link
Contributor

@IgorHorta IgorHorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering how we should deal with the value difference in the highlight view?

Image

Copy link
Contributor

@IgorHorta IgorHorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scott-ray-wilson scott-ray-wilson merged commit 8a82bdb into main Feb 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants