Skip to content

feature(frontend): manage secret metadata from overview page#5337

Merged
scott-ray-wilson merged 8 commits intomainfrom
SECRETS-79
Feb 3, 2026
Merged

feature(frontend): manage secret metadata from overview page#5337
scott-ray-wilson merged 8 commits intomainfrom
SECRETS-79

Conversation

@scott-ray-wilson
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson commented Feb 1, 2026

Context

This PR adds management of secret metadata to the overview page

Also adds several new v3 components:

  • switch (variants and stories)
  • field components
  • label

Screenshots

CleanShot 2026-01-31 at 18 20 35@2x

Steps to verify the change

  • Test adding, updating and editing secret metadata
  • test permissions edit / read view

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

maidul98 commented Feb 1, 2026 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 1, 2026

Greptile Overview

Greptile Summary

This PR adds secret metadata management to the overview page, allowing users to add, edit, and view key-value metadata on secrets with optional encryption.

Key Changes:

  • Added new v3 components: Switch (with variants), Field components, Label, and CreatableSelect
  • Implemented SecretMetadataForm for managing metadata entries with key, value, and encryption toggle
  • Extended SecretEditTableRow with metadata popover and icon trigger
  • Updated type definitions to include isEncrypted field on secretMetadata
  • Properly implements permission checks for editing metadata

Notes:

  • Check that the backend API supports the isEncrypted field in the secretMetadata array
  • Verify that encrypted metadata filtering works correctly in UI and API as mentioned in the form description

Confidence Score: 4/5

  • Safe to merge with one verification needed regarding backend API support
  • Frontend implementation is clean with proper permission checks and form validation. The only concern is verifying backend API compatibility with the new isEncrypted field
  • Verify that backend/docs/API support the isEncrypted field in secretMetadata

Important Files Changed

Filename Overview
frontend/src/components/v3/generic/Switch/Switch.tsx New Switch component with variant support and size options
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretMetadataForm.tsx Form for managing secret metadata with key-value pairs and encryption toggle
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretTagForm.tsx Form for managing secret tags with create and select functionality
frontend/src/pages/secret-manager/OverviewPage/components/SecretTableRow/SecretEditTableRow.tsx Added metadata management popover with icon trigger and form integration
frontend/src/hooks/api/secrets/types.ts Added isEncrypted optional field to secretMetadata type definitions

akhilmhdh
akhilmhdh reviewed Feb 2, 2026
View reviewed changes
Copy link
Member

@akhilmhdh akhilmhdh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but these changes will be done by @scott-ray-wilson later

  • Switch doesn't feel like it's ON
image
  • Missing project.enforceEncryptedMetadata check in form. Will be great to have that validation as well

akhilmhdh
akhilmhdh previously approved these changes Feb 3, 2026
View reviewed changes
akhilmhdh
akhilmhdh previously approved these changes Feb 3, 2026
View reviewed changes
@scott-ray-wilson scott-ray-wilson merged commit de1899e into main Feb 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilmhdh akhilmhdh akhilmhdh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scott-ray-wilson @maidul98 @akhilmhdh