Skip to content

feature(frontend): manage tags on overview page#5335

Merged
scott-ray-wilson merged 1 commit intomainfrom
SECRETS-78
Feb 2, 2026
Merged

feature(frontend): manage tags on overview page#5335
scott-ray-wilson merged 1 commit intomainfrom
SECRETS-78

Conversation

@scott-ray-wilson
Copy link
Contributor

Context

  • This PR adds tag management to the overview page
  • adds v3 createable select component

Screenshots

CleanShot 2026-01-31 at 12 17 05@2x

Steps to verify the change

  • Test adding / removing tags from secret
  • test adding creating tags
  • test permission behavior on tag popover (read tags, create tags, edit secret)

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 31, 2026

Greptile Overview

Greptile Summary

This PR adds tag management functionality to the secret overview page, allowing users to add, create, and remove tags from secrets directly in the UI.

Key Changes:

  • Added new CreatableSelect v3 component as a reusable wrapper around react-select/creatable
  • Created SecretTagForm component for managing tags with proper permission checks (Read tags, Create tags, Edit secret)
  • Integrated tag management popover into SecretEditTableRow with TagsIcon indicator
  • Input validation uses slugSchema to ensure tags are slug-friendly (lowercase letters, numbers, hyphens)
  • Properly handles disabled states for imported secrets and personal overrides
  • UI provides clear feedback on permission restrictions and approval workflows

Code Quality:

  • Clean implementation with proper TypeScript types
  • Good permission boundary enforcement
  • No regex vulnerabilities detected (uses validated slugify library)
  • Follows existing patterns in the codebase

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects well-structured frontend code with proper permission checks, input validation, and no security vulnerabilities detected. The changes are isolated to the frontend tag management UI and follow existing patterns.
  • No files require special attention

@scott-ray-wilson scott-ray-wilson merged commit 31deaa3 into main Feb 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants