Skip to content

chore: improve CA details page and migrate to V3 components#5332

Merged
carlosmonastyrski merged 5 commits intomainfrom
feat/PKI-109
Feb 2, 2026
Merged

chore: improve CA details page and migrate to V3 components#5332
carlosmonastyrski merged 5 commits intomainfrom
feat/PKI-109

Conversation

@carlosmonastyrski
Copy link
Contributor

Context

Refactored the Certificate Authority details page to use v3 components and restructured the layout.

Screenshots

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Read the contributing guide

@maidul98
Copy link
Collaborator

maidul98 commented Jan 31, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 31, 2026

Greptile Overview

Greptile Summary

This PR refactors the Certificate Authority details page to use v3 components (UnstableCard, UnstableTable, UnstableDropdownMenu, etc.) instead of v2 components, improving UI consistency across the codebase.

  • Migrated all table components from v2 to v3 (UnstableTable, UnstableTableBody, UnstableTableCell, etc.)
  • Replaced v2 dropdown menus with v3 UnstableDropdownMenu components
  • Introduced a new CaCertDetailsSection component to display certificate details (CN, O, OU, C, ST, L)
  • Restructured layout with responsive flex patterns for better mobile support
  • Moved CA action buttons (Renew CA, Generate Certificate, Install Certificate) from CaDetailsSection to CaCertificatesSection card header
  • Replaced FontAwesome icons with Lucide icons in several places
  • Added copy-to-clipboard functionality for CRL URLs
  • Simplified component structure using Detail/DetailGroup patterns for displaying CA information

This is a pure UI refactoring with no business logic changes, API modifications, or security implications.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - pure UI component migration with no logic changes
  • This is a straightforward UI refactoring that migrates components from v2 to v3. No business logic changes, no API modifications, no security vulnerabilities introduced, and no breaking changes detected
  • No files require special attention

Important Files Changed

Filename Overview
frontend/src/pages/cert-manager/CertAuthDetailsByIDPage/CertAuthDetailsByIDPage.tsx Migrated to v3 components (UnstableDropdownMenu, Button), improved layout with responsive flex structure
frontend/src/pages/cert-manager/CertAuthDetailsByIDPage/components/CaCertDetailsSection.tsx New component created to display certificate details (CN, O, OU, C, ST, L) using v3 card components
frontend/src/pages/cert-manager/CertAuthDetailsByIDPage/components/CaDetailsSection.tsx Migrated to v3 components with Detail/DetailGroup pattern, removed action buttons (moved to CaCertificatesSection), simplified structure

Copy link
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great overall, few comments

@scott-ray-wilson scott-ray-wilson self-requested a review February 2, 2026 22:56
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, approved provided CI checks pass 👍

@carlosmonastyrski carlosmonastyrski merged commit 8b868ce into main Feb 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants