fix(pki): return helpful error for malformed JSON on certificate endpoint for CSR#5331
Merged
saifsmailbox98 merged 2 commits intomainfrom Feb 2, 2026
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Greptile OverviewGreptile SummaryThis PR improves error handling for the Key Changes
Issues Found
Confidence Score: 4/5
Important Files Changed
|
carlosmonastyrski
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When users send a CSR (Certificate Signing Request) to
POST /api/v1/cert-manager/certificateswith literal newlines instead of escaped\ncharacters, the JSON parser fails before reaching the route handler. This is a common user mistake when copying/pasting CSR content directly into JSON.Before: Returns a generic 500 Internal Server Error with "Something went wrong" message, which provides no indication of what went wrong.
After: Returns a 400 Bad Request with a helpful message: "Invalid JSON in request body. If you are sending a Certificate Signing Request (CSR), ensure newlines are escaped as \n characters, not literal line breaks."
Example of the issue:
Screenshots
N/A - API-only change
Steps to verify the change
/api/v1/cert-manager/certificateswith a properly escaped CSR (newlines as\n) - should work normally (200){ "statusCode": 400, "message": "Invalid JSON in request body. If you are sending a Certificate Signing Request (CSR), ensure newlines are escaped as \\n characters, not literal line breaks.", "error": "BadRequestError" }Type
Checklist
type(scope): short description(scope is optional, e.g.,fix: prevent crash on syncorfix(api): handle null response).