fix(api): include create secrets when resolving tags in bulk upsert#5324
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile OverviewGreptile SummaryFixed a crash in the bulk upsert operation that occurred when creating new secrets with tags. The bug happened because tag resolution only included secrets being updated ( The fix includes both Confidence Score: 5/5
Important Files Changed
|
|
@scott-ray-wilson @varonix0 are you planning to merge this ? |
scott-ray-wilson
left a comment
There was a problem hiding this comment.
Confirmed resolves bug, please address lint issue
|
can you please check again, fixed the linting issue. |
scott-ray-wilson
left a comment
There was a problem hiding this comment.
Still has a lint issue, you should be able to run npm run lint:fix in the backend to address this
|
Fixed |
scott-ray-wilson
left a comment
There was a problem hiding this comment.
LGTM, thanks for contributing!
Fixes a crash in bulk upsert by resolving tags for both created and updated secrets before permission checks.
fixes #5268