Skip to content

docs: make secrets management video responsive#5322

Merged
vmatsiiako merged 1 commit intomainfrom
responsive-secrets-video-docs
Jan 30, 2026
Merged

docs: make secrets management video responsive#5322
vmatsiiako merged 1 commit intomainfrom
responsive-secrets-video-docs

Conversation

@dangtony98
Copy link
Collaborator

@dangtony98 dangtony98 commented Jan 30, 2026

Summary

  • Replace fixed video dimensions (720x405) with responsive CSS using intrinsic ratio technique
  • Video now scales properly across all screen sizes (mobile, tablet, desktop)
  • Maintains 16:9 aspect ratio using paddingBottom: 56.25%

Test plan

  • Verify video displays correctly on desktop browsers
  • Test responsiveness on mobile viewport sizes
  • Confirm 16:9 aspect ratio is maintained at all widths

🤖 Generated with Claude Code

@dangtony98 @claude
docs: make secrets management video responsive
366495c 
Use intrinsic ratio technique (padding-bottom: 56.25%) to maintain 16:9
aspect ratio across all screen sizes instead of fixed dimensions.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@dangtony98 dangtony98 requested a review from vmatsiiako January 30, 2026 05:43
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 30, 2026

Greptile Overview

Greptile Summary

This PR replaces the fixed-size YouTube video embed (720x405) with a responsive design that adapts to all screen sizes while maintaining the 16:9 aspect ratio. The implementation uses the standard intrinsic ratio technique with paddingBottom: 56.25% and absolute positioning for the iframe.

  • Removed fixed width and height attributes from the iframe
  • Implemented responsive container with proper aspect ratio padding
  • Added maxWidth: "100%" to prevent overflow on larger screens
  • Video will now display correctly on mobile, tablet, and desktop viewports

The change is purely presentational and improves the user experience on smaller devices.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is a straightforward CSS update to documentation that improves responsive design without affecting any application logic, API, or backend code. The responsive CSS technique used is a standard, well-established pattern
  • No files require special attention

Important Files Changed

Filename Overview
docs/documentation/platform/secrets-mgmt/overview.mdx Converted fixed-width YouTube embed to responsive design using intrinsic ratio technique

@maidul98
Copy link
Collaborator

maidul98 commented Jan 30, 2026

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@dangtony98 dangtony98 requested review from jakehulberg and removed request for vmatsiiako January 30, 2026 05:46
@dangtony98 dangtony98 requested a review from vmatsiiako January 30, 2026 05:47
@vmatsiiako vmatsiiako merged commit ad3a8a9 into main Jan 30, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmatsiiako vmatsiiako vmatsiiako approved these changes

@jakehulberg jakehulberg Awaiting requested review from jakehulberg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dangtony98 @maidul98 @vmatsiiako